Checkstyle Results
The following document contains the results of
Checkstyle.
Summary
| Files | Infos | Warnings | Errors |
|---|
| 391 | 0 | 0 | 3626 |
Files
nl/toolforge/karma/core/ErrorCode.java
| Error | Line |
|---|
| Missing a Javadoc comment. |
38
|
|
| Missing a Javadoc comment. |
40
|
|
| Missing a Javadoc comment. |
42
|
|
| Missing a Javadoc comment. |
44
|
|
| Missing a Javadoc comment. |
53
|
|
| Line is longer than 120 characters. |
56
|
|
| Parameter errorCode should be final. |
61
|
|
| 'errorCode' hides a field. |
61
|
|
| Expected @param tag for 'errorCode'. |
61
|
|
| Missing a Javadoc comment. |
69
|
|
| Parameter messageBundle should be final. |
69
|
|
| 'messageBundle' hides a field. |
69
|
|
| Redundant 'final' modifier. |
78
|
|
| Parameter messageArguments should be final. |
78
|
|
| 'messageArguments' hides a field. |
78
|
|
| Line is longer than 120 characters. |
91
|
|
| Parameter locale should be final. |
94
|
|
| Missing a Javadoc comment. |
150
|
|
| Avoid inline conditionals. |
151
|
|
| Missing a Javadoc comment. |
154
|
|
| Parameter o should be final. |
154
|
|
| 'if' construct must use '{}'s. |
155
|
|
| 'if' construct must use '{}'s. |
156
|
|
| 'if' construct must use '{}'s. |
160
|
|
| Avoid inline conditionals. |
160
|
|
| Missing a Javadoc comment. |
165
|
|
| Avoid inline conditionals. |
166
|
|
| Missing a Javadoc comment. |
169
|
nl/toolforge/karma/core/KarmaException.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
38
|
|
| First sentence should end with a period. |
40
|
|
| First sentence should end with a period. |
48
|
|
| Missing a Javadoc comment. |
53
|
|
| Missing a Javadoc comment. |
82
|
|
| Variable 'errorCode' must be private and have accessor methods. |
82
|
|
| Missing a Javadoc comment. |
84
|
|
| Variable 'messageArguments' must be private and have accessor methods. |
84
|
|
| Parameter errorCode should be final. |
91
|
|
| 'errorCode' hides a field. |
91
|
|
| Parameter errorCode should be final. |
101
|
|
| 'errorCode' hides a field. |
101
|
|
| Parameter messageArguments should be final. |
101
|
|
| 'messageArguments' hides a field. |
101
|
|
| Parameter errorCode should be final. |
112
|
|
| 'errorCode' hides a field. |
112
|
|
| Parameter t should be final. |
112
|
|
| Parameter errorCode should be final. |
124
|
|
| 'errorCode' hides a field. |
124
|
|
| Parameter messageArguments should be final. |
124
|
|
| 'messageArguments' hides a field. |
124
|
|
| Parameter t should be final. |
124
|
|
| Line is longer than 120 characters. |
133
|
|
| Method 'getErrorCode' is not designed for extension - needs to be abstract, final or empty. |
136
|
|
| Line is longer than 120 characters. |
141
|
|
| Line is longer than 120 characters. |
142
|
|
| Method 'getErrorMessage' is not designed for extension - needs to be abstract, final or empty. |
149
|
|
| Method 'getMessage' is not designed for extension - needs to be abstract, final or empty. |
169
|
|
| Missing a Javadoc comment. |
169
|
nl/toolforge/karma/core/KarmaRuntimeException.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
31
|
|
| Variable 'errorCode' must be private and have accessor methods. |
31
|
|
| Missing a Javadoc comment. |
33
|
|
| Variable 'messageArguments' must be private and have accessor methods. |
33
|
|
| Missing a Javadoc comment. |
35
|
|
| Parameter t should be final. |
35
|
|
| Missing a Javadoc comment. |
39
|
|
| Parameter message should be final. |
39
|
|
| Parameter message should be final. |
48
|
|
| Parameter t should be final. |
48
|
|
| Missing a Javadoc comment. |
52
|
|
| Parameter errorCode should be final. |
52
|
|
| 'errorCode' hides a field. |
52
|
|
| Missing a Javadoc comment. |
56
|
|
| Parameter errorCode should be final. |
56
|
|
| 'errorCode' hides a field. |
56
|
|
| Parameter t should be final. |
56
|
|
| Missing a Javadoc comment. |
61
|
|
| Parameter errorCode should be final. |
61
|
|
| 'errorCode' hides a field. |
61
|
|
| Parameter messageArguments should be final. |
61
|
|
| 'messageArguments' hides a field. |
61
|
|
| Missing a Javadoc comment. |
66
|
|
| Parameter errorCode should be final. |
66
|
|
| 'errorCode' hides a field. |
66
|
|
| Parameter messageArguments should be final. |
66
|
|
| 'messageArguments' hides a field. |
66
|
|
| Parameter t should be final. |
66
|
nl/toolforge/karma/core/MavenEnvironment.java
| Error | Line |
|---|
|
| Utility classes should not have a public or default constructor. |
33
|
|
| Missing a Javadoc comment. |
44
|
|
| '+' is not followed by whitespace. |
45
|
|
| Missing a Javadoc comment. |
47
|
|
| Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
47
|
|
| Missing a Javadoc comment. |
49
|
|
| Must have at least one statement. |
51
|
|
| Missing a Javadoc comment. |
56
|
|
| Missing a Javadoc comment. |
66
|
|
| Line is longer than 120 characters. |
68
|
|
| Avoid inline conditionals. |
68
|
nl/toolforge/karma/core/Patch.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
27
|
|
| Missing a Javadoc comment. |
36
|
|
| Name 'INITIAL_PATCH' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
36
|
|
| Variable 'INITIAL_PATCH' must be private and have accessor methods. |
36
|
|
| Parameter patchNumber should be final. |
44
|
|
| Expected @param tag for 'patchNumber'. |
44
|
|
| Method 'getPatternString' is not designed for extension - needs to be abstract, final or empty. |
48
|
|
| Missing a Javadoc comment. |
48
|
|
| Line has trailing spaces. |
54
|
|
| Method 'increaseMajor' is not designed for extension - needs to be abstract, final or empty. |
57
|
nl/toolforge/karma/core/Version.java
| Error | Line |
|---|
|
| Line has trailing spaces. |
29
|
|
| Missing a Javadoc comment. |
33
|
|
| Name 'VERSION_PATTERN_STRING' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
33
|
|
| Variable 'VERSION_PATTERN_STRING' must be private and have accessor methods. |
33
|
|
| Name 'INITIAL_VERSION' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
39
|
|
| Variable 'INITIAL_VERSION' must be private and have accessor methods. |
39
|
|
| '+' is not preceded with whitespace. |
39
|
|
| '+' is not followed by whitespace. |
39
|
|
| '+' is not preceded with whitespace. |
39
|
|
| '+' is not followed by whitespace. |
39
|
|
| Missing a Javadoc comment. |
41
|
|
| Missing a Javadoc comment. |
42
|
|
| Missing a Javadoc comment. |
43
|
|
| Missing a Javadoc comment. |
45
|
|
| Missing a Javadoc comment. |
47
|
|
| Parameter versionIdentifier should be final. |
54
|
|
| Expected @param tag for 'versionIdentifier'. |
54
|
|
| Method 'getPatternString' is not designed for extension - needs to be abstract, final or empty. |
74
|
|
| Missing a Javadoc comment. |
74
|
|
| Expected an @return tag. |
83
|
|
| '+' is not preceded with whitespace. |
84
|
|
| '+' is not followed by whitespace. |
84
|
|
| '+' is not preceded with whitespace. |
84
|
|
| '+' is not followed by whitespace. |
84
|
|
| Expected an @return tag. |
93
|
|
| Method 'createPatch' is not designed for extension - needs to be abstract, final or empty. |
93
|
|
| Parameter patchNumber should be final. |
93
|
|
| Expected @param tag for 'patchNumber'. |
93
|
|
| Parameter versionDigits should be final. |
103
|
|
| 'versionDigits' hides a field. |
103
|
|
| '+' should be on a new line. |
107
|
|
| 'if' construct must use '{}'s. |
114
|
|
| Empty statement. |
114
|
|
| Missing a Javadoc comment. |
122
|
|
| Method 'getVersionNumber' is not designed for extension - needs to be abstract, final or empty. |
129
|
|
| Missing a Javadoc comment. |
129
|
|
| Missing a Javadoc comment. |
133
|
|
| Missing a Javadoc comment. |
137
|
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
146
|
|
| Missing a Javadoc comment. |
150
|
|
| Missing a Javadoc comment. |
154
|
|
| Parameter o should be final. |
154
|
|
| Parameter o should be final. |
169
|
|
| Method 'setDigit' is not designed for extension - needs to be abstract, final or empty. |
200
|
|
| Missing a Javadoc comment. |
200
|
|
| Parameter index should be final. |
200
|
|
| Parameter nextDigit should be final. |
200
|
|
| Missing a Javadoc comment. |
205
|
|
| Parameter version should be final. |
205
|
|
| Missing a Javadoc comment. |
209
|
|
| Parameter version should be final. |
209
|
|
| Method 'increaseMajor' is not designed for extension - needs to be abstract, final or empty. |
224
|
|
| Line has trailing spaces. |
228
|
|
| Method 'clone' is not designed for extension - needs to be abstract, final or empty. |
229
|
|
| Missing a Javadoc comment. |
229
|
nl/toolforge/karma/core/VersionCreationFactory.java
| Error | Line |
|---|
|
| Method 'createObject' is not designed for extension - needs to be abstract, final or empty. |
28
|
|
| Missing a Javadoc comment. |
28
|
|
| Parameter attributes should be final. |
28
|
nl/toolforge/karma/core/boot/AdminStore.java
| Error | Line |
|---|
|
| Line does not match expected header line of '/*'. |
1
|
|
| Missing a Javadoc comment. |
20
|
|
| Missing a Javadoc comment. |
21
|
|
| Missing a Javadoc comment. |
22
|
|
| Missing a Javadoc comment. |
24
|
|
| Missing a Javadoc comment. |
25
|
|
| Missing a Javadoc comment. |
27
|
|
| Missing a Javadoc comment. |
29
|
|
| Variable 'module' must be private and have accessor methods. |
29
|
|
| Missing a Javadoc comment. |
31
|
|
| Parameter workingContext should be final. |
31
|
|
| 'workingContext' hides a field. |
31
|
|
| Missing a Javadoc comment. |
40
|
|
| Parameter workingContext should be final. |
40
|
|
| 'workingContext' hides a field. |
40
|
|
| Parameter moduleName should be final. |
40
|
|
| 'moduleName' hides a field. |
40
|
|
| Parameter location should be final. |
40
|
|
| 'location' hides a field. |
40
|
|
| Missing a Javadoc comment. |
46
|
|
| Missing a Javadoc comment. |
50
|
|
| Parameter location should be final. |
50
|
|
| 'location' hides a field. |
50
|
|
| Missing a Javadoc comment. |
59
|
|
| Missing a Javadoc comment. |
63
|
|
| Missing a Javadoc comment. |
80
|
|
| Parameter moduleName should be final. |
80
|
|
| 'moduleName' hides a field. |
80
|
|
| Missing a Javadoc comment. |
84
|
|
| Missing a Javadoc comment. |
88
|
|
| Method 'checkConfiguration' is not designed for extension - needs to be abstract, final or empty. |
95
|
|
| Missing a Javadoc comment. |
95
|
nl/toolforge/karma/core/boot/ConfigurationItem.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
27
|
|
| Missing a Javadoc comment. |
28
|
|
| Missing a Javadoc comment. |
29
|
|
| Missing a Javadoc comment. |
30
|
|
| Missing a Javadoc comment. |
32
|
|
| Parameter property should be final. |
32
|
|
| 'property' hides a field. |
32
|
|
| Parameter label should be final. |
32
|
|
| 'label' hides a field. |
32
|
|
| Parameter defaultValue should be final. |
32
|
|
| 'defaultValue' hides a field. |
32
|
|
| Missing a Javadoc comment. |
36
|
|
| Parameter property should be final. |
36
|
|
| 'property' hides a field. |
36
|
|
| Parameter label should be final. |
36
|
|
| 'label' hides a field. |
36
|
|
| Parameter defaultValue should be final. |
36
|
|
| 'defaultValue' hides a field. |
36
|
|
| Parameter scrambled should be final. |
36
|
|
| 'scrambled' hides a field. |
36
|
|
| Method 'getProperty' is not designed for extension - needs to be abstract, final or empty. |
43
|
|
| Missing a Javadoc comment. |
43
|
|
| Method 'getLabel' is not designed for extension - needs to be abstract, final or empty. |
47
|
|
| Missing a Javadoc comment. |
47
|
|
| Method 'getDefaultValue' is not designed for extension - needs to be abstract, final or empty. |
51
|
|
| Missing a Javadoc comment. |
51
|
|
| Method 'isScrambled' is not designed for extension - needs to be abstract, final or empty. |
55
|
|
| Missing a Javadoc comment. |
55
|
nl/toolforge/karma/core/boot/Karma.java
| Error | Line |
|---|
|
| Line does not match expected header line of '/*'. |
1
|
|
| Line is longer than 120 characters. |
15
|
nl/toolforge/karma/core/boot/LocationStore.java
| Error | Line |
|---|
|
| Line does not match expected header line of '/*'. |
1
|
|
| Missing a Javadoc comment. |
17
|
|
| Parameter workingContext should be final. |
17
|
|
| Missing a Javadoc comment. |
21
|
|
| Parameter workingContext should be final. |
21
|
|
| Parameter moduleName should be final. |
21
|
|
| Parameter location should be final. |
21
|
|
| Missing a Javadoc comment. |
25
|
|
| Redundant 'final' modifier. |
25
|
|
| Missing a Javadoc comment. |
51
|
|
| Missing a Javadoc comment. |
53
|
|
| Parameter name should be final. |
53
|
|
| Parameter location should be final. |
53
|
|
| Method 'getLayoutTemplate' is not designed for extension - needs to be abstract, final or empty. |
57
|
|
| Missing a Javadoc comment. |
57
|
nl/toolforge/karma/core/boot/ManifestStore.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'Karma core - Core of the Karma application'. |
2
|
|
| Missing a Javadoc comment. |
31
|
|
| Parameter workingContext should be final. |
31
|
|
| Missing a Javadoc comment. |
35
|
|
| Parameter workingContext should be final. |
35
|
|
| Parameter moduleName should be final. |
35
|
|
| Parameter location should be final. |
35
|
|
| Expected an @return tag. |
43
|
|
| Missing a Javadoc comment. |
47
|
|
| Redundant 'final' modifier. |
47
|
|
| Parameter releaseName should be final. |
80
|
|
| Expected @throws tag for 'AuthenticationException'. |
80
|
|
| Expected @throws tag for 'VersionControlException'. |
80
|
|
| Missing a Javadoc comment. |
88
|
|
| Missing a Javadoc comment. |
90
|
|
| Parameter name should be final. |
90
|
|
| Parameter location should be final. |
90
|
|
| Method 'getLayoutTemplate' is not designed for extension - needs to be abstract, final or empty. |
94
|
|
| Missing a Javadoc comment. |
94
|
nl/toolforge/karma/core/boot/Property.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
30
|
|
| Missing a Javadoc comment. |
31
|
|
| Missing a Javadoc comment. |
33
|
|
| Missing a Javadoc comment. |
37
|
|
| Parameter name should be final. |
37
|
|
| 'name' hides a field. |
37
|
|
| Parameter value should be final. |
37
|
|
| 'value' hides a field. |
37
|
|
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
42
|
|
| Missing a Javadoc comment. |
42
|
|
| Method 'setName' is not designed for extension - needs to be abstract, final or empty. |
46
|
|
| Missing a Javadoc comment. |
46
|
|
| Parameter name should be final. |
46
|
|
| 'name' hides a field. |
46
|
|
| Method 'getValue' is not designed for extension - needs to be abstract, final or empty. |
50
|
|
| Missing a Javadoc comment. |
50
|
|
| Method 'setValue' is not designed for extension - needs to be abstract, final or empty. |
54
|
|
| Missing a Javadoc comment. |
54
|
|
| Parameter value should be final. |
54
|
|
| 'value' hides a field. |
54
|
nl/toolforge/karma/core/boot/Store.java
| Error | Line |
|---|
|
| Line does not match expected header line of '/*'. |
1
|
|
| Expected @throws tag for 'WorkingContextException'. |
20
|
|
| Line is longer than 120 characters. |
31
|
|
| Missing a Javadoc comment. |
38
|
|
| Missing a Javadoc comment. |
40
|
nl/toolforge/karma/core/boot/WorkingContext.java
| Error | Line |
|---|
|
| Line is longer than 120 characters. |
42
|
|
| Missing a Javadoc comment. |
55
|
|
| 'static' modifier out of order with the JLS suggestions. |
55
|
|
| Missing a Javadoc comment. |
57
|
|
| 'static' modifier out of order with the JLS suggestions. |
57
|
|
| Missing a Javadoc comment. |
59
|
|
| 'static' modifier out of order with the JLS suggestions. |
59
|
|
| Avoid inline conditionals. |
97
|
|
| Line is longer than 120 characters. |
98
|
|
| Avoid inline conditionals. |
98
|
|
| Line is longer than 120 characters. |
109
|
|
| Missing a Javadoc comment. |
118
|
|
| Missing a Javadoc comment. |
135
|
|
| Missing a Javadoc comment. |
136
|
|
| Missing a Javadoc comment. |
147
|
|
| Missing a Javadoc comment. |
149
|
|
| Missing a Javadoc comment. |
151
|
|
| Missing a Javadoc comment. |
152
|
|
| Missing a Javadoc comment. |
153
|
|
| Missing a Javadoc comment. |
155
|
|
| Missing a Javadoc comment. |
157
|
|
| Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
157
|
|
| Missing a Javadoc comment. |
159
|
|
| Parameter workingContext should be final. |
168
|
|
| 'workingContext' hides a field. |
168
|
|
| Parameter workingContext should be final. |
181
|
|
| 'workingContext' hides a field. |
181
|
|
| Parameter configBaseDir should be final. |
181
|
|
| '+' should be on a new line. |
205
|
|
| '+' should be on a new line. |
206
|
|
| Missing a Javadoc comment. |
212
|
|
| Parameter configuration should be final. |
212
|
|
| 'configuration' hides a field. |
212
|
|
| '+' is not preceded with whitespace. |
258
|
|
| '+' is not followed by whitespace. |
258
|
|
| '+' is not preceded with whitespace. |
258
|
|
| '+' is not followed by whitespace. |
258
|
|
| '+' is not preceded with whitespace. |
260
|
|
| '+' is not followed by whitespace. |
260
|
|
| '+' is not preceded with whitespace. |
260
|
|
| '+' is not followed by whitespace. |
260
|
|
| Expected @throws tag for 'IOException'. |
268
|
|
| Line is longer than 120 characters. |
305
|
|
| Missing a Javadoc comment. |
375
|
|
| Line is longer than 120 characters. |
385
|
|
| Expected an @return tag. |
391
|
|
| Expected @throws tag for 'LocationException'. |
399
|
nl/toolforge/karma/core/boot/WorkingContextConfiguration.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
79
|
|
| Missing a Javadoc comment. |
81
|
|
| Missing a Javadoc comment. |
85
|
|
| Missing a Javadoc comment. |
86
|
|
| Missing a Javadoc comment. |
88
|
|
| Missing a Javadoc comment. |
90
|
|
| Parameter workingContext should be final. |
100
|
|
| 'workingContext' hides a field. |
100
|
|
| Missing a Javadoc comment. |
110
|
|
| Parameter manifestStore should be final. |
137
|
|
| 'manifestStore' hides a field. |
137
|
|
| Parameter locationStore should be final. |
146
|
|
| 'locationStore' hides a field. |
146
|
|
| Parameter key should be final. |
156
|
|
| Expected @param tag for 'key'. |
156
|
|
| Parameter name should be final. |
171
|
|
| Expected @param tag for 'name'. |
171
|
|
| Parameter value should be final. |
171
|
|
| Expected @param tag for 'value'. |
171
|
|
| Must have at least one statement. |
186
|
|
| '+' should be on a new line. |
290
|
|
| '+' should be on a new line. |
323
|
|
| '+' should be on a new line. |
324
|
|
| Must have at least one statement. |
347
|
|
| Missing a Javadoc comment. |
392
|
nl/toolforge/karma/core/boot/WorkingContextException.java
| Error | Line |
|---|
|
| Line does not match expected header line of '/*'. |
1
|
|
| Missing a Javadoc comment. |
9
|
|
| Parameter message should be final. |
9
|
|
| Missing a Javadoc comment. |
13
|
|
| Parameter cause should be final. |
13
|
|
| Missing a Javadoc comment. |
17
|
|
| Parameter message should be final. |
17
|
|
| Parameter cause should be final. |
17
|
nl/toolforge/karma/core/boot/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
nl/toolforge/karma/core/bundle/BundleCache.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
nl/toolforge/karma/core/bundle/BundleCache.java
| Error | Line |
|---|
|
| Class BundleCache should be declared as final. |
37
|
|
| Line contains a tab character. |
39
|
|
| Missing a Javadoc comment. |
39
|
|
| Line contains a tab character. |
41
|
|
| Missing a Javadoc comment. |
41
|
|
| Line contains a tab character. |
43
|
|
| Line contains a tab character. |
44
|
|
| Line contains a tab character. |
45
|
|
| Line is longer than 120 characters. |
46
|
|
| Line contains a tab character. |
46
|
|
| Line contains a tab character. |
47
|
|
| Line contains a tab character. |
48
|
|
| Line contains a tab character. |
49
|
|
| Line contains a tab character. |
50
|
|
| Line contains a tab character. |
51
|
|
| Line contains a tab character. |
52
|
|
| Line contains a tab character. |
53
|
|
| Line contains a tab character. |
55
|
|
| Missing a Javadoc comment. |
55
|
|
| Line contains a tab character. |
57
|
|
| Line contains a tab character. |
58
|
|
| Line contains a tab character. |
59
|
|
| Line is longer than 120 characters. |
60
|
|
| Line contains a tab character. |
60
|
|
| Line contains a tab character. |
61
|
|
| Line contains a tab character. |
62
|
|
| Line contains a tab character. |
63
|
|
| Line contains a tab character. |
64
|
|
| Line contains a tab character. |
65
|
|
| Line contains a tab character. |
66
|
|
| Line contains a tab character. |
67
|
|
| Line contains a tab character. |
69
|
|
| Missing a Javadoc comment. |
69
|
|
| Line contains a tab character. |
72
|
|
| Missing a Javadoc comment. |
72
|
|
| Line contains a tab character. |
74
|
|
| Line contains a tab character. |
75
|
|
| Line contains a tab character. |
76
|
|
| Line contains a tab character. |
77
|
|
| Line contains a tab character. |
78
|
|
| Line contains a tab character. |
79
|
|
| 'static' modifier out of order with the JLS suggestions. |
79
|
|
| Line contains a tab character. |
80
|
|
| Avoid inline conditionals. |
80
|
|
| Line contains a tab character. |
81
|
|
| Line contains a tab character. |
84
|
|
| Missing a Javadoc comment. |
84
|
|
| Line contains a tab character. |
85
|
|
| Line contains a tab character. |
87
|
|
| Line contains a tab character. |
88
|
|
| Line contains a tab character. |
89
|
|
| Line contains a tab character. |
92
|
|
| Line contains a tab character. |
93
|
|
| Line contains a tab character. |
94
|
|
| Line contains a tab character. |
95
|
|
| Line contains a tab character. |
96
|
|
| Line contains a tab character. |
97
|
|
| Line contains a tab character. |
98
|
|
| Parameter bundleKey should be final. |
98
|
|
| Parameter bundle should be final. |
98
|
|
| Line contains a tab character. |
100
|
|
| Line is longer than 120 characters. |
101
|
|
| Line contains a tab character. |
101
|
|
| Line contains a tab character. |
102
|
|
| Line contains a tab character. |
104
|
|
| Line contains a tab character. |
105
|
|
| Line contains a tab character. |
106
|
|
| Line contains a tab character. |
108
|
|
| Line contains a tab character. |
109
|
|
| Line contains a tab character. |
110
|
|
| Line contains a tab character. |
112
|
|
| Line contains a tab character. |
113
|
|
| Line contains a tab character. |
115
|
|
| Line contains a tab character. |
116
|
|
| Line contains a tab character. |
117
|
|
| Line contains a tab character. |
118
|
|
| Line contains a tab character. |
119
|
|
| Line contains a tab character. |
120
|
|
| Line contains a tab character. |
121
|
|
| Parameter bundleKey should be final. |
121
|
|
| Line contains a tab character. |
123
|
|
| Line contains a tab character. |
124
|
|
| Line contains a tab character. |
125
|
|
| Line is longer than 120 characters. |
126
|
|
| Line contains a tab character. |
126
|
|
| Line contains a tab character. |
127
|
|
| Line contains a tab character. |
129
|
|
| Line contains a tab character. |
130
|
|
| Line contains a tab character. |
131
|
|
| Line contains a tab character. |
132
|
|
| 'final' modifier out of order with the JLS suggestions. |
132
|
|
| Line contains a tab character. |
133
|
|
| Line contains a tab character. |
134
|
nl/toolforge/karma/core/bundle/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
nl/toolforge/karma/core/cmd/Command.java
| Error | Line |
|---|
|
| Unclosed HTML tag found: <a href="http://jakarta.apache.org/commons/cli/apidocs/org/a |
28
|
|
| Extra HTML tag found: </code> package. |
28
|
|
| Line contains a tab character. |
38
|
|
| Line contains a tab character. |
39
|
|
| Line contains a tab character. |
40
|
|
| Line contains a tab character. |
41
|
|
| Line contains a tab character. |
42
|
|
| Redundant 'public' modifier. |
42
|
|
| Line contains a tab character. |
44
|
|
| Line contains a tab character. |
45
|
|
| Line contains a tab character. |
46
|
|
| Line contains a tab character. |
47
|
|
| Line contains a tab character. |
48
|
|
| Line contains a tab character. |
49
|
|
| Redundant 'public' modifier. |
49
|
|
| Line contains a tab character. |
51
|
|
| Line is longer than 120 characters. |
52
|
|
| Line contains a tab character. |
52
|
|
| Line contains a tab character. |
53
|
|
| Line contains a tab character. |
54
|
|
| Line contains a tab character. |
55
|
|
| Line contains a tab character. |
56
|
|
| Redundant 'public' modifier. |
56
|
|
| Line contains a tab character. |
58
|
|
| Line contains a tab character. |
59
|
|
| Line contains a tab character. |
60
|
|
| Expected an @return tag. |
61
|
|
| Line contains a tab character. |
61
|
|
| Redundant 'public' modifier. |
61
|
|
| Line contains a tab character. |
63
|
|
| Line contains a tab character. |
64
|
|
| Line contains a tab character. |
65
|
|
| Line is longer than 120 characters. |
66
|
|
| Line contains a tab character. |
66
|
|
| Line contains a tab character. |
68
|
|
| Line contains a tab character. |
69
|
|
| Redundant 'public' modifier. |
69
|
|
| Redundant 'public' modifier. |
74
|
|
| Line contains a tab character. |
76
|
|
| Line contains a tab character. |
77
|
|
| Line contains a tab character. |
78
|
|
| Line contains a tab character. |
79
|
|
| Line contains a tab character. |
80
|
|
| Line contains a tab character. |
81
|
|
| Redundant 'public' modifier. |
81
|
|
| Line contains a tab character. |
83
|
|
| Missing a Javadoc comment. |
83
|
|
| Redundant 'public' modifier. |
83
|
|
| Line contains a tab character. |
85
|
|
| Line is longer than 120 characters. |
86
|
|
| Line contains a tab character. |
86
|
|
| Line contains a tab character. |
87
|
|
| Line contains a tab character. |
88
|
|
| Line contains a tab character. |
89
|
|
| Line contains a tab character. |
90
|
|
| Line contains a tab character. |
91
|
|
| Redundant 'public' modifier. |
91
|
|
| Redundant 'public' modifier. |
98
|
|
| Expected @param tag for 'responseListener'. |
98
|
|
| Redundant 'public' modifier. |
103
|
|
| Expected @param tag for 'responseListener'. |
103
|
|
| Redundant 'public' modifier. |
110
|
nl/toolforge/karma/core/cmd/CommandContext.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
62
|
|
| Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
62
|
|
| Missing a Javadoc comment. |
64
|
|
| Missing a Javadoc comment. |
65
|
|
| Missing a Javadoc comment. |
66
|
|
| Missing a Javadoc comment. |
68
|
|
| Missing a Javadoc comment. |
70
|
|
| Missing a Javadoc comment. |
71
|
|
| Missing a Javadoc comment. |
72
|
|
| Parameter workingContext should be final. |
77
|
|
| 'workingContext' hides a field. |
77
|
|
| Expected @param tag for 'workingContext'. |
77
|
|
| Missing a Javadoc comment. |
81
|
|
| Line is longer than 120 characters. |
88
|
|
| Line is longer than 120 characters. |
90
|
|
| Parameter handler should be final. |
93
|
|
| 'handler' hides a field. |
93
|
|
| Parameter updateStores should be final. |
93
|
|
| Expected @throws tag for 'CommandException'. |
93
|
|
| Missing a Javadoc comment. |
128
|
|
| Line is longer than 120 characters. |
134
|
|
| Line is longer than 120 characters. |
143
|
|
| Line is longer than 120 characters. |
196
|
|
| Line is longer than 120 characters. |
239
|
|
| Parameter manifestName should be final. |
241
|
|
| Expected @param tag for 'manifestName'. |
241
|
|
| Expected @throws tag for 'LocationException'. |
241
|
|
| Parameter newManifest should be final. |
259
|
|
| Expected @param tag for 'newManifest'. |
259
|
|
| Parameter commandLine should be final. |
308
|
|
| Parameter command should be final. |
330
|
|
| Expected @throws tag for 'CommandException'. |
330
|
|
| Missing a Javadoc comment. |
361
|
|
| Parameter handler should be final. |
361
|
|
| 'handler' hides a field. |
361
|
|
| Missing a Javadoc comment. |
365
|
|
| Parameter module should be final. |
390
|
|
| Expected an @return tag. |
401
|
|
| Parameter workingContext should be final. |
410
|
|
| 'workingContext' hides a field. |
410
|
|
| Expected @param tag for 'workingContext'. |
410
|
nl/toolforge/karma/core/cmd/CommandDescriptor.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
37
|
|
| Missing a Javadoc comment. |
38
|
|
| Missing a Javadoc comment. |
39
|
|
| Missing a Javadoc comment. |
40
|
|
| Missing a Javadoc comment. |
41
|
|
| Missing a Javadoc comment. |
43
|
|
| Missing a Javadoc comment. |
44
|
|
| Missing a Javadoc comment. |
46
|
|
| Parameter name should be final. |
46
|
|
| 'name' hides a field. |
46
|
|
| Parameter aliasString should be final. |
46
|
|
| 'aliasString' hides a field. |
46
|
|
| Line has trailing spaces. |
67
|
|
| Expected an @return tag. |
70
|
|
| Missing a Javadoc comment. |
74
|
|
| Parameter aliasString should be final. |
74
|
|
| 'aliasString' hides a field. |
74
|
|
| Missing a Javadoc comment. |
86
|
|
| Missing a Javadoc comment. |
90
|
|
| Missing a Javadoc comment. |
94
|
|
| Parameter description should be final. |
94
|
|
| 'description' hides a field. |
94
|
|
| Parameter options should be final. |
101
|
|
| 'options' hides a field. |
101
|
|
| Missing a Javadoc comment. |
105
|
|
| Missing a Javadoc comment. |
113
|
|
| Missing a Javadoc comment. |
117
|
|
| Parameter className should be final. |
117
|
|
| 'className' hides a field. |
117
|
|
| Missing a Javadoc comment. |
121
|
|
| Parameter helpText should be final. |
121
|
|
| 'helpText' hides a field. |
121
|
|
| Missing a Javadoc comment. |
125
|
|
| Definition of 'equals()' without corresponding definition of 'hashCode()'. |
137
|
|
| Parameter o should be final. |
137
|
|
| Missing a Javadoc comment. |
166
|
nl/toolforge/karma/core/cmd/CommandDescriptorMap.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
nl/toolforge/karma/core/cmd/CommandDescriptorMap.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'Karma core - Core of the Karma application'. |
2
|
|
| Missing a Javadoc comment. |
18
|
|
| Missing a Javadoc comment. |
20
|
|
| Method 'add' is not designed for extension - needs to be abstract, final or empty. |
28
|
|
| Parameter newDescriptor should be final. |
28
|
|
| Expected @param tag for 'newDescriptor'. |
28
|
|
| Method 'addAll' is not designed for extension - needs to be abstract, final or empty. |
82
|
|
| Parameter anotherMap should be final. |
82
|
|
| Expected an @return tag. |
93
|
|
| Method 'values' is not designed for extension - needs to be abstract, final or empty. |
93
|
|
| Method 'keySet' is not designed for extension - needs to be abstract, final or empty. |
102
|
|
| Expected an @return tag. |
113
|
|
| Method 'get' is not designed for extension - needs to be abstract, final or empty. |
113
|
|
| Parameter name should be final. |
113
|
|
| Method 'size' is not designed for extension - needs to be abstract, final or empty. |
125
|
nl/toolforge/karma/core/cmd/CommandException.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
nl/toolforge/karma/core/cmd/CommandException.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
31
|
|
| Missing a Javadoc comment. |
32
|
|
| Missing a Javadoc comment. |
34
|
|
| Missing a Javadoc comment. |
39
|
|
| Missing a Javadoc comment. |
41
|
|
| Name 'MISSING_OPTION' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
45
|
|
| Variable 'MISSING_OPTION' must be private and have accessor methods. |
45
|
|
| Name 'MISSING_ARGUMENT' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
47
|
|
| Variable 'MISSING_ARGUMENT' must be private and have accessor methods. |
47
|
|
| Name 'INVALID_ARGUMENT' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
49
|
|
| Variable 'INVALID_ARGUMENT' must be private and have accessor methods. |
49
|
|
| Line is longer than 120 characters. |
83
|
|
| Missing a Javadoc comment. |
96
|
|
| Missing a Javadoc comment. |
102
|
|
| Missing a Javadoc comment. |
104
|
|
| Missing a Javadoc comment. |
106
|
|
| Line is longer than 120 characters. |
107
|
|
| Missing a Javadoc comment. |
112
|
|
| Missing a Javadoc comment. |
114
|
|
| Missing a Javadoc comment. |
116
|
|
| Missing a Javadoc comment. |
120
|
|
| Line is longer than 120 characters. |
126
|
|
| Missing a Javadoc comment. |
130
|
|
| Parameter errorCode should be final. |
130
|
|
| 'errorCode' hides a field. |
130
|
|
| Missing a Javadoc comment. |
134
|
|
| Parameter t should be final. |
134
|
|
| Parameter errorCode should be final. |
134
|
|
| 'errorCode' hides a field. |
134
|
|
| Missing a Javadoc comment. |
138
|
|
| Parameter errorCode should be final. |
138
|
|
| 'errorCode' hides a field. |
138
|
|
| Parameter messageArguments should be final. |
138
|
|
| 'messageArguments' hides a field. |
138
|
|
| Missing a Javadoc comment. |
144
|
|
| Parameter t should be final. |
144
|
|
| Parameter errorCode should be final. |
144
|
|
| 'errorCode' hides a field. |
144
|
|
| Parameter messageArguments should be final. |
144
|
|
| 'messageArguments' hides a field. |
144
|
|
| Method 'getMessage' is not designed for extension - needs to be abstract, final or empty. |
150
|
|
| Missing a Javadoc comment. |
150
|
|
| Expected an @return tag. |
161
|
|
| Missing a Javadoc comment. |
165
|
nl/toolforge/karma/core/cmd/CommandFactory.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
55
|
|
| Missing a Javadoc comment. |
59
|
|
| Missing a Javadoc comment. |
61
|
|
| Missing a Javadoc comment. |
62
|
|
| First sentence should end with a period. |
64
|
|
| Expected @throws tag for 'CommandLoadException'. |
67
|
|
| Missing a Javadoc comment. |
71
|
|
| Expected @throws tag for 'CommandLoadException'. |
101
|
|
| Parameter commandLineString should be final. |
117
|
|
| '-' is not preceded with whitespace. |
167
|
|
| '-' is not followed by whitespace. |
167
|
|
| Missing a Javadoc comment. |
197
|
|
| Parameter commandName should be final. |
197
|
|
| Parameter arguments should be final. |
197
|
|
| Expected an @return tag. |
268
|
|
| Parameter name should be final. |
268
|
|
| Expected @param tag for 'name'. |
268
|
|
| Missing a Javadoc comment. |
272
|
|
| Expected an @return tag. |
280
|
|
| Parameter commandId should be final. |
280
|
|
| Expected @param tag for 'commandId'. |
280
|
|
| Line is longer than 120 characters. |
287
|
nl/toolforge/karma/core/cmd/CommandLoadException.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
31
|
|
| Missing a Javadoc comment. |
32
|
|
| Missing a Javadoc comment. |
34
|
|
| Missing a Javadoc comment. |
36
|
|
| Missing a Javadoc comment. |
38
|
|
| Line has trailing spaces. |
39
|
|
| Missing a Javadoc comment. |
40
|
|
| Missing a Javadoc comment. |
42
|
|
| Parameter errorCode should be final. |
42
|
|
| 'errorCode' hides a field. |
42
|
|
| Missing a Javadoc comment. |
46
|
|
| Parameter errorCode should be final. |
46
|
|
| 'errorCode' hides a field. |
46
|
|
| Parameter messageArguments should be final. |
46
|
|
| 'messageArguments' hides a field. |
46
|
|
| Missing a Javadoc comment. |
52
|
|
| Parameter t should be final. |
52
|
|
| Parameter errorCode should be final. |
52
|
|
| 'errorCode' hides a field. |
52
|
|
| Parameter messageArguments should be final. |
52
|
|
| 'messageArguments' hides a field. |
52
|
|
| Method 'getMessage' is not designed for extension - needs to be abstract, final or empty. |
58
|
|
| Missing a Javadoc comment. |
58
|
|
| Expected an @return tag. |
69
|
|
| Missing a Javadoc comment. |
73
|
nl/toolforge/karma/core/cmd/CommandLoader.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
47
|
|
| First sentence should end with a period. |
48
|
|
| Missing a Javadoc comment. |
62
|
|
| Missing a Javadoc comment. |
65
|
|
| Expected @throws tag for 'CommandLoadException'. |
87
|
|
| Line is longer than 120 characters. |
100
|
|
| Parameter resource should be final. |
137
|
|
| Expected @throws tag for 'CommandLoadException'. |
137
|
|
| Line is longer than 120 characters. |
143
|
|
| Line is longer than 120 characters. |
146
|
|
| Expected an @return tag. |
155
|
|
| Expected @throws tag for 'CommandLoadException'. |
155
|
|
| Line is longer than 120 characters. |
160
|
|
| Line is longer than 120 characters. |
165
|
|
| Line is longer than 120 characters. |
168
|
|
| Missing a Javadoc comment. |
172
|
nl/toolforge/karma/core/cmd/CommandResponse.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
43
|
|
| Missing a Javadoc comment. |
45
|
|
| '{' is not followed by whitespace. |
50
|
|
| '}' is not preceded with whitespace. |
50
|
|
| Method 'addEvent' is not designed for extension - needs to be abstract, final or empty. |
58
|
|
| Parameter event should be final. |
58
|
|
| ';' is followed by whitespace. |
60
|
|
| Parameter responseListener should be final. |
82
|
|
| Expected @param tag for 'responseListener'. |
82
|
|
| Parameter responseListener should be final. |
89
|
|
| Expected @param tag for 'responseListener'. |
89
|
nl/toolforge/karma/core/cmd/CompositeCommand.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
37
|
|
| Parameter commandDescriptor should be final. |
37
|
|
| Parameter event should be final. |
45
|
|
| Expected @param tag for 'event'. |
45
|
|
| Parameter event should be final. |
51
|
|
| Expected @param tag for 'event'. |
51
|
|
| Parameter event should be final. |
57
|
|
| Expected @param tag for 'event'. |
57
|
nl/toolforge/karma/core/cmd/DefaultCommand.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
38
|
|
| Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
38
|
|
| Line contains a tab character. |
40
|
|
| Missing a Javadoc comment. |
40
|
|
| Line contains a tab character. |
42
|
|
| Missing a Javadoc comment. |
42
|
|
| Line contains a tab character. |
43
|
|
| Missing a Javadoc comment. |
43
|
|
| Line contains a tab character. |
44
|
|
| Missing a Javadoc comment. |
44
|
|
| Line contains a tab character. |
45
|
|
| Missing a Javadoc comment. |
45
|
|
| Line contains a tab character. |
46
|
|
| Missing a Javadoc comment. |
46
|
|
| Missing a Javadoc comment. |
48
|
|
| Line contains a tab character. |
51
|
|
| Line contains a tab character. |
52
|
|
| Line contains a tab character. |
53
|
|
| Line contains a tab character. |
54
|
|
| Line contains a tab character. |
55
|
|
| Parameter descriptor should be final. |
55
|
|
| Line contains a tab character. |
57
|
|
| Line contains a tab character. |
58
|
|
| Line contains a tab character. |
59
|
|
| Line contains a tab character. |
60
|
|
| Line contains a tab character. |
61
|
|
| Line contains a tab character. |
62
|
|
| Line contains a tab character. |
63
|
|
| Line contains a tab character. |
64
|
|
| Line contains a tab character. |
66
|
|
| Line contains a tab character. |
67
|
|
| Line contains a tab character. |
68
|
|
| Line contains a tab character. |
69
|
|
| Line contains a tab character. |
70
|
|
| Line contains a tab character. |
71
|
|
| Line contains a tab character. |
72
|
|
| Parameter contextRef should be final. |
72
|
|
| 'contextRef' hides a field. |
72
|
|
| Line contains a tab character. |
76
|
|
| Line contains a tab character. |
77
|
|
| Line contains a tab character. |
79
|
|
| Line contains a tab character. |
80
|
|
| Line contains a tab character. |
81
|
|
| Line contains a tab character. |
82
|
|
| Line contains a tab character. |
83
|
|
| Line contains a tab character. |
84
|
|
| Line contains a tab character. |
85
|
|
| Line contains a tab character. |
86
|
|
| Line contains a tab character. |
88
|
|
| Line contains a tab character. |
89
|
|
| Line contains a tab character. |
91
|
|
| Line contains a tab character. |
92
|
|
| Line contains a tab character. |
93
|
|
| Line contains a tab character. |
94
|
|
| Line contains a tab character. |
95
|
|
| Line contains a tab character. |
96
|
|
| Line contains a tab character. |
107
|
|
| Line contains a tab character. |
108
|
|
| Line contains a tab character. |
109
|
|
| Line contains a tab character. |
110
|
|
| Line contains a tab character. |
111
|
|
| Line contains a tab character. |
112
|
|
| Line contains a tab character. |
113
|
|
| Line contains a tab character. |
114
|
|
| Line contains a tab character. |
116
|
|
| Missing a Javadoc comment. |
116
|
|
| Parameter commandLine should be final. |
116
|
|
| 'commandLine' hides a field. |
116
|
|
| Line contains a tab character. |
117
|
|
| Line contains a tab character. |
118
|
|
| Line contains a tab character. |
120
|
|
| Line is longer than 120 characters. |
121
|
|
| Line contains a tab character. |
121
|
|
| Line contains a tab character. |
122
|
|
| Line contains a tab character. |
123
|
|
| Line contains a tab character. |
124
|
|
| Line contains a tab character. |
125
|
|
| Line contains a tab character. |
126
|
|
| Line contains a tab character. |
127
|
|
| Line contains a tab character. |
128
|
|
| Missing a Javadoc comment. |
130
|
|
| Parameter responseListener should be final. |
130
|
|
| 'responseListener' hides a field. |
130
|
|
| '+' is not preceded with whitespace. |
136
|
|
| '+' is not followed by whitespace. |
136
|
|
| '+' is not preceded with whitespace. |
136
|
|
| '+' is not followed by whitespace. |
136
|
|
| Missing a Javadoc comment. |
140
|
|
| Parameter responseListener should be final. |
140
|
|
| 'responseListener' hides a field. |
140
|
|
| '+' is not preceded with whitespace. |
145
|
|
| '+' is not followed by whitespace. |
145
|
|
| '+' is not preceded with whitespace. |
145
|
|
| '+' is not followed by whitespace. |
145
|
|
| Line contains a tab character. |
158
|
|
| Line contains a tab character. |
159
|
|
| Line contains a tab character. |
160
|
|
| Line contains a tab character. |
161
|
|
| Line contains a tab character. |
162
|
|
| Line contains a tab character. |
163
|
|
| Line contains a tab character. |
164
|
|
| Line contains a tab character. |
165
|
|
| Line contains a tab character. |
167
|
|
| Line contains a tab character. |
168
|
|
| Line contains a tab character. |
169
|
|
| Line contains a tab character. |
170
|
|
| Line contains a tab character. |
171
|
|
| Line contains a tab character. |
172
|
|
| Line contains a tab character. |
173
|
|
| Method 'getHelp' is not designed for extension - needs to be abstract, final or empty. |
173
|
|
| Line contains a tab character. |
174
|
|
| Line contains a tab character. |
175
|
|
| Line contains a tab character. |
177
|
|
| Line contains a tab character. |
178
|
|
| Line contains a tab character. |
179
|
|
| Line contains a tab character. |
180
|
|
| Line contains a tab character. |
181
|
|
| Line contains a tab character. |
182
|
|
| Line contains a tab character. |
183
|
|
| Line contains a tab character. |
184
|
nl/toolforge/karma/core/cmd/ExternalPropertySupport.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
nl/toolforge/karma/core/cmd/KarmaInitializationCommand.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
54
|
|
| Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
54
|
|
| Missing a Javadoc comment. |
56
|
|
| Missing a Javadoc comment. |
58
|
|
| Missing a Javadoc comment. |
59
|
|
| Parameter updateStores should be final. |
64
|
|
| 'updateStores' hides a field. |
64
|
|
| Expected @param tag for 'updateStores'. |
64
|
|
| Expected @throws tag for 'CommandException'. |
73
|
|
| Line has trailing spaces. |
80
|
|
| Line is longer than 120 characters. |
108
|
|
| Line is longer than 120 characters. |
115
|
|
| Line is longer than 120 characters. |
123
|
|
| Line is longer than 120 characters. |
127
|
|
| Must have at least one statement. |
129
|
|
| Missing a Javadoc comment. |
181
|
|
| Parameter context should be final. |
181
|
|
| Parameter commandLine should be final. |
190
|
|
| '{' is not followed by whitespace. |
190
|
|
| '}' is not preceded with whitespace. |
190
|
|
| First sentence should end with a period. |
192
|
|
| Missing a Javadoc comment. |
201
|
|
| Redundant 'final' modifier. |
201
|
|
| Parameter responseListener should be final. |
201
|
|
| Missing a Javadoc comment. |
205
|
|
| Redundant 'final' modifier. |
205
|
|
| Parameter responseListener should be final. |
205
|
|
| Missing a Javadoc comment. |
209
|
|
| Missing a Javadoc comment. |
213
|
nl/toolforge/karma/core/cmd/StatusMessage.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
28
|
|
| Parameter message should be final. |
28
|
|
| Missing a Javadoc comment. |
32
|
|
| Parameter message should be final. |
32
|
|
| Parameter messageParameters should be final. |
32
|
nl/toolforge/karma/core/cmd/digester/CommandDescriptorCreationFactory.java
| Error | Line |
|---|
|
| Method 'createObject' is not designed for extension - needs to be abstract, final or empty. |
33
|
|
| Missing a Javadoc comment. |
33
|
|
| Parameter attributes should be final. |
33
|
nl/toolforge/karma/core/cmd/digester/OptionDescriptorCreationFactory.java
| Error | Line |
|---|
|
| Method 'createObject' is not designed for extension - needs to be abstract, final or empty. |
33
|
|
| Missing a Javadoc comment. |
33
|
|
| Parameter attributes should be final. |
33
|
|
| Avoid inline conditionals. |
38
|
|
| Avoid inline conditionals. |
42
|
nl/toolforge/karma/core/cmd/digester/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
nl/toolforge/karma/core/cmd/event/AbstractMessage.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
nl/toolforge/karma/core/cmd/event/AbstractMessage.java
| Error | Line |
|---|
|
| Line contains a tab character. |
31
|
|
| Missing a Javadoc comment. |
31
|
|
| Line contains a tab character. |
33
|
|
| Missing a Javadoc comment. |
33
|
|
| Parameter message should be final. |
33
|
|
| 'message' hides a field. |
33
|
|
| Line contains a tab character. |
34
|
|
| Line contains a tab character. |
35
|
|
| Line contains a tab character. |
37
|
|
| Line is longer than 120 characters. |
38
|
|
| Line contains a tab character. |
38
|
|
| Line contains a tab character. |
40
|
|
| Line contains a tab character. |
41
|
|
| Line contains a tab character. |
42
|
|
| Line contains a tab character. |
43
|
|
| Line contains a tab character. |
44
|
|
| Parameter message should be final. |
44
|
|
| 'message' hides a field. |
44
|
|
| Parameter messageParameters should be final. |
44
|
|
| Line contains a tab character. |
46
|
|
| Line contains a tab character. |
47
|
|
| Line contains a tab character. |
48
|
|
| Line contains a tab character. |
49
|
|
| Line contains a tab character. |
50
|
|
| Line contains a tab character. |
51
|
|
| Line contains a tab character. |
52
|
|
| Line contains a tab character. |
54
|
|
| Line contains a tab character. |
55
|
|
| Line contains a tab character. |
56
|
|
| Line contains a tab character. |
57
|
|
| Line contains a tab character. |
58
|
|
| Line contains a tab character. |
59
|
|
| Method 'getMessageText' is not designed for extension - needs to be abstract, final or empty. |
59
|
|
| Line contains a tab character. |
60
|
|
| Line contains a tab character. |
61
|
nl/toolforge/karma/core/cmd/event/CommandFailedEvent.java
| Error | Line |
|---|
|
| Parameter command should be final. |
39
|
|
| Parameter exception should be final. |
39
|
|
| Expected @param tag for 'exception'. |
39
|
|
| Expected an @return tag. |
46
|
nl/toolforge/karma/core/cmd/event/CommandFinishedEvent.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
31
|
|
| Missing a Javadoc comment. |
32
|
|
| Parameter command should be final. |
39
|
|
| Parameter startTime should be final. |
39
|
|
| Expected @param tag for 'startTime'. |
39
|
|
| Expected an @return tag. |
59
|
|
| '1000' is a magic number. |
61
|
|
| Line is longer than 120 characters. |
62
|
|
| '/' is not preceded with whitespace. |
64
|
|
| '/' is not followed by whitespace. |
64
|
|
| '1000' is a magic number. |
64
|
|
| Line is longer than 120 characters. |
65
|
|
| '/' is not preceded with whitespace. |
65
|
|
| '/' is not followed by whitespace. |
65
|
|
| '1000' is a magic number. |
65
|
|
| Line is longer than 120 characters. |
67
|
|
| '/' is not preceded with whitespace. |
67
|
|
| '/' is not followed by whitespace. |
67
|
|
| '1000' is a magic number. |
67
|
nl/toolforge/karma/core/cmd/event/CommandResponseEvent.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
32
|
|
| Missing a Javadoc comment. |
34
|
|
| Parameter command should be final. |
41
|
|
| 'command' hides a field. |
41
|
|
| Parameter command should be final. |
51
|
|
| 'command' hides a field. |
51
|
|
| Parameter priority should be final. |
51
|
|
| 'priority' hides a field. |
51
|
|
| Expected an @return tag. |
73
|
|
| Method 'getCommand' is not designed for extension - needs to be abstract, final or empty. |
80
|
nl/toolforge/karma/core/cmd/event/CommandResponseListener.java
| Error | Line |
|---|
|
| Redundant 'public' modifier. |
37
|
|
| Expected @param tag for 'event'. |
37
|
|
| Redundant 'public' modifier. |
44
|
|
| Expected @param tag for 'event'. |
44
|
|
| Redundant 'public' modifier. |
51
|
|
| Expected @param tag for 'event'. |
51
|
nl/toolforge/karma/core/cmd/event/CommandStartedEvent.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
31
|
|
| Parameter command should be final. |
38
|
|
| Empty statement. |
40
|
|
| Expected an @return tag. |
55
|
nl/toolforge/karma/core/cmd/event/ErrorEvent.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
33
|
|
| Parameter command should be final. |
41
|
|
| Parameter code should be final. |
41
|
|
| 'code' hides a field. |
41
|
|
| Parameter code should be final. |
51
|
|
| 'code' hides a field. |
51
|
|
| Parameter command should be final. |
62
|
|
| Parameter code should be final. |
62
|
|
| 'code' hides a field. |
62
|
|
| Parameter messageArguments should be final. |
62
|
|
| Parameter code should be final. |
74
|
|
| 'code' hides a field. |
74
|
|
| Parameter messageArguments should be final. |
74
|
nl/toolforge/karma/core/cmd/event/Event.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| interfaces should describe a type and hence have methods. |
7
|
|
| Missing a Javadoc comment. |
8
|
|
| Redundant 'public' modifier. |
8
|
|
| Missing a Javadoc comment. |
9
|
|
| Redundant 'public' modifier. |
9
|
|
| Missing a Javadoc comment. |
10
|
|
| Redundant 'public' modifier. |
10
|
nl/toolforge/karma/core/cmd/event/ExceptionEvent.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
31
|
|
| Parameter command should be final. |
38
|
|
| Parameter exception should be final. |
38
|
|
| 'exception' hides a field. |
38
|
|
| Expected @param tag for 'exception'. |
38
|
|
| Expected an @return tag. |
46
|
|
| Method 'getEventMessage' is not designed for extension - needs to be abstract, final or empty. |
46
|
|
| Method 'getCause' is not designed for extension - needs to be abstract, final or empty. |
55
|
nl/toolforge/karma/core/cmd/event/Message.java
| Error | Line |
|---|
|
| Line contains a tab character. |
31
|
|
| Line contains a tab character. |
32
|
|
| Line contains a tab character. |
33
|
|
| Line contains a tab character. |
34
|
|
| Line contains a tab character. |
35
|
|
| Line contains a tab character. |
36
|
|
| Line contains a tab character. |
37
|
|
| Redundant 'public' modifier. |
37
|
nl/toolforge/karma/core/cmd/event/MessageEvent.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
31
|
|
| Parameter command should be final. |
39
|
|
| Parameter priority should be final. |
39
|
|
| Parameter command should be final. |
50
|
|
| Parameter priority should be final. |
50
|
|
| Parameter message should be final. |
50
|
|
| 'message' hides a field. |
50
|
|
| Parameter command should be final. |
60
|
|
| Parameter message should be final. |
60
|
|
| 'message' hides a field. |
60
|
|
| Expected @param tag for 'message'. |
60
|
|
| Parameter message should be final. |
70
|
|
| 'message' hides a field. |
70
|
nl/toolforge/karma/core/cmd/event/MessageHelper.java
| Error | Line |
|---|
|
| Utility classes should not have a public or default constructor. |
27
|
|
| Expected an @return tag. |
39
|
|
| Parameter label should be final. |
39
|
|
| Parameter message should be final. |
39
|
nl/toolforge/karma/core/cmd/event/SimpleMessage.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
30
|
|
| Missing a Javadoc comment. |
31
|
|
| Parameter message should be final. |
38
|
|
| 'message' hides a field. |
38
|
|
| Parameter message should be final. |
48
|
|
| 'message' hides a field. |
48
|
|
| Parameter messageArguments should be final. |
48
|
|
| 'messageArguments' hides a field. |
48
|
|
| Expected @param tag for 'messageArguments'. |
48
|
|
| First sentence should end with a period. |
58
|
|
| Method 'getMessageText' is not designed for extension - needs to be abstract, final or empty. |
63
|
|
| Line has trailing spaces. |
64
|
nl/toolforge/karma/core/cmd/event/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
nl/toolforge/karma/core/cmd/impl/AbstractBuildCommand.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
59
|
|
| Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
59
|
|
| Missing a Javadoc comment. |
61
|
|
| Variable 'module' must be private and have accessor methods. |
61
|
|
| Missing a Javadoc comment. |
63
|
|
| Missing a Javadoc comment. |
64
|
|
| Missing a Javadoc comment. |
65
|
|
| Parameter descriptor should be final. |
72
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
76
|
|
| Missing a Javadoc comment. |
76
|
|
| Expected an @return tag. |
123
|
|
| Method 'getCurrentModule' is not designed for extension - needs to be abstract, final or empty. |
123
|
|
| Expected an @return tag. |
134
|
|
| Method 'getBuildEnvironment' is not designed for extension - needs to be abstract, final or empty. |
134
|
|
| Expected an @return tag. |
143
|
|
| Expected @throws tag for 'ModuleTypeException'. |
143
|
|
| Method 'getAntProject' is not designed for extension - needs to be abstract, final or empty. |
165
|
|
| Parameter buildFile should be final. |
165
|
|
| Expected @throws tag for 'CommandException'. |
165
|
|
| Expected an @return tag. |
186
|
|
| Method 'getProjectInstance' is not designed for extension - needs to be abstract, final or empty. |
186
|
|
| Expected @throws tag for 'CommandException'. |
186
|
|
| 'logger' hides a field. |
191
|
|
| Method 'executeMkdir' is not designed for extension - needs to be abstract, final or empty. |
220
|
|
| Parameter dir should be final. |
220
|
|
| Expected @param tag for 'dir'. |
220
|
|
| Expected @throws tag for 'CommandException'. |
220
|
|
| Method 'executeDelete' is not designed for extension - needs to be abstract, final or empty. |
235
|
|
| Parameter dir should be final. |
235
|
|
| Expected @param tag for 'dir'. |
235
|
|
| Parameter includes should be final. |
235
|
|
| Expected @param tag for 'includes'. |
235
|
|
| Expected @throws tag for 'CommandException'. |
235
|
|
| Method 'executeDelete' is not designed for extension - needs to be abstract, final or empty. |
257
|
|
| Missing a Javadoc comment. |
257
|
|
| Parameter dir should be final. |
257
|
|
| Missing a Javadoc comment. |
281
|
|
| Redundant 'final' modifier. |
281
|
|
| Parameter buildFile should be final. |
281
|
|
| Missing a Javadoc comment. |
306
|
|
| Parameter tmpBuildFileLocation should be final. |
306
|
nl/toolforge/karma/core/cmd/impl/BuildAllModules.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
53
|
|
| Missing a Javadoc comment. |
54
|
|
| Missing a Javadoc comment. |
55
|
|
| Missing a Javadoc comment. |
57
|
|
| Parameter descriptor should be final. |
57
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
61
|
|
| Missing a Javadoc comment. |
61
|
|
| '||' should be on a new line. |
90
|
|
| ')' is preceded with whitespace. |
91
|
|
| '(' is followed by whitespace. |
105
|
|
| ')' is preceded with whitespace. |
105
|
|
| Missing a Javadoc comment. |
112
|
|
| Parameter collection should be final. |
112
|
|
| Method 'getCommandResponse' is not designed for extension - needs to be abstract, final or empty. |
143
|
|
| Missing a Javadoc comment. |
143
|
nl/toolforge/karma/core/cmd/impl/BuildModule.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
65
|
|
| Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
65
|
|
| Missing a Javadoc comment. |
67
|
|
| Missing a Javadoc comment. |
69
|
|
| Parameter descriptor should be final. |
69
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
73
|
|
| Missing a Javadoc comment. |
73
|
|
| '(' is followed by whitespace. |
104
|
|
| '||' should be on a new line. |
104
|
|
| Line is longer than 120 characters. |
115
|
|
| '+' is not preceded with whitespace. |
117
|
|
| '+' is not followed by whitespace. |
117
|
|
| '(' is followed by whitespace. |
127
|
|
| ')' is preceded with whitespace. |
127
|
|
| Line is longer than 120 characters. |
147
|
|
| Line is longer than 120 characters. |
150
|
|
| Line is longer than 120 characters. |
168
|
|
| Method 'getCommandResponse' is not designed for extension - needs to be abstract, final or empty. |
172
|
|
| Missing a Javadoc comment. |
172
|
nl/toolforge/karma/core/cmd/impl/CleanAll.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
39
|
|
| Missing a Javadoc comment. |
41
|
|
| Parameter descriptor should be final. |
41
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
50
|
|
| Expected @throws tag for 'CommandException'. |
50
|
|
| Method 'getCommandResponse' is not designed for extension - needs to be abstract, final or empty. |
66
|
|
| Missing a Javadoc comment. |
66
|
nl/toolforge/karma/core/cmd/impl/CleanModule.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
40
|
|
| Missing a Javadoc comment. |
42
|
|
| Parameter descriptor should be final. |
42
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
46
|
|
| Missing a Javadoc comment. |
46
|
|
| Line is longer than 120 characters. |
54
|
|
| Method 'getCommandResponse' is not designed for extension - needs to be abstract, final or empty. |
62
|
|
| Missing a Javadoc comment. |
62
|
nl/toolforge/karma/core/cmd/impl/CommandFaker.java
| Error | Line |
|---|
|
| Line contains a tab character. |
35
|
|
| Missing a Javadoc comment. |
35
|
|
| Parameter descriptor should be final. |
35
|
|
| Line contains a tab character. |
36
|
|
| Line contains a tab character. |
38
|
|
| Line contains a tab character. |
39
|
|
| Line contains a tab character. |
41
|
|
| Missing a Javadoc comment. |
41
|
|
| Line contains a tab character. |
42
|
|
| Line contains a tab character. |
43
|
|
| Missing a Javadoc comment. |
45
|
nl/toolforge/karma/core/cmd/impl/CreateDistribution.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
33
|
|
| Missing a Javadoc comment. |
35
|
|
| Parameter descriptor should be final. |
35
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
39
|
|
| Missing a Javadoc comment. |
39
|
|
| Method 'getCommandResponse' is not designed for extension - needs to be abstract, final or empty. |
49
|
|
| Missing a Javadoc comment. |
49
|
nl/toolforge/karma/core/cmd/impl/CreateModuleCommand.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
50
|
|
| Missing a Javadoc comment. |
52
|
|
| Missing a Javadoc comment. |
54
|
|
| Parameter descriptor should be final. |
54
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
61
|
|
| Expected @throws tag for 'CommandException'. |
61
|
|
| Line is longer than 120 characters. |
95
|
|
| Line is longer than 120 characters. |
105
|
|
| Method 'getCommandResponse' is not designed for extension - needs to be abstract, final or empty. |
117
|
|
| Missing a Javadoc comment. |
117
|
nl/toolforge/karma/core/cmd/impl/CreatePassword.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
44
|
|
| Variable 'response' must be private and have accessor methods. |
44
|
|
| Parameter descriptor should be final. |
50
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
57
|
|
| Expected @throws tag for 'CommandException'. |
57
|
|
| Line is longer than 120 characters. |
76
|
|
| Line is longer than 120 characters. |
83
|
|
| Line is longer than 120 characters. |
101
|
|
| Line is longer than 120 characters. |
120
|
|
| Line is longer than 120 characters. |
122
|
|
| Line is longer than 120 characters. |
126
|
|
| Line is longer than 120 characters. |
128
|
|
| Method 'getCommandResponse' is not designed for extension - needs to be abstract, final or empty. |
132
|
|
| Missing a Javadoc comment. |
132
|
nl/toolforge/karma/core/cmd/impl/CreateRelease.java
| Error | Line |
|---|
|
| First sentence should end with a period. |
52
|
|
| Missing a Javadoc comment. |
61
|
|
| Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
61
|
|
| Missing a Javadoc comment. |
63
|
|
| Missing a Javadoc comment. |
65
|
|
| Parameter descriptor should be final. |
65
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
69
|
|
| Method length is 168 lines (max allowed is 150). |
69
|
|
| Missing a Javadoc comment. |
69
|
|
| Line is longer than 120 characters. |
100
|
|
| Line is longer than 120 characters. |
106
|
|
| Line is longer than 120 characters. |
114
|
|
| '100' is a magic number. |
121
|
|
| Line is longer than 120 characters. |
142
|
|
| Line is longer than 120 characters. |
169
|
|
| Line is longer than 120 characters. |
203
|
|
| Line is longer than 120 characters. |
214
|
|
| Line is longer than 120 characters. |
218
|
|
| Method 'getCommandResponse' is not designed for extension - needs to be abstract, final or empty. |
238
|
|
| Missing a Javadoc comment. |
238
|
|
| Missing a Javadoc comment. |
242
|
|
| Parameter module should be final. |
242
|
|
| Parameter useRemote should be final. |
242
|
nl/toolforge/karma/core/cmd/impl/DeleteWorkingContext.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
44
|
|
| Missing a Javadoc comment. |
46
|
|
| Variable 'response' must be private and have accessor methods. |
46
|
|
| Parameter descriptor should be final. |
52
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
61
|
|
| Expected @throws tag for 'CommandException'. |
61
|
|
| Line is longer than 120 characters. |
80
|
|
| Line is longer than 120 characters. |
81
|
|
| Method 'getCommandResponse' is not designed for extension - needs to be abstract, final or empty. |
84
|
|
| Missing a Javadoc comment. |
84
|
nl/toolforge/karma/core/cmd/impl/DocAllModules.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
45
|
|
| Missing a Javadoc comment. |
47
|
|
| Parameter descriptor should be final. |
47
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
51
|
|
| Missing a Javadoc comment. |
51
|
|
| Line is longer than 120 characters. |
92
|
|
| Method 'getCommandResponse' is not designed for extension - needs to be abstract, final or empty. |
100
|
|
| Missing a Javadoc comment. |
100
|
nl/toolforge/karma/core/cmd/impl/DocModule.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
39
|
|
| Missing a Javadoc comment. |
40
|
|
| Missing a Javadoc comment. |
41
|
|
| Missing a Javadoc comment. |
42
|
|
| Missing a Javadoc comment. |
44
|
|
| Variable 'response' must be private and have accessor methods. |
44
|
|
| Missing a Javadoc comment. |
46
|
|
| Parameter descriptor should be final. |
46
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
54
|
|
| Method 'getCommandResponse' is not designed for extension - needs to be abstract, final or empty. |
78
|
|
| Missing a Javadoc comment. |
78
|
|
| Method 'getSourceDirectory' is not designed for extension - needs to be abstract, final or empty. |
82
|
|
| Missing a Javadoc comment. |
82
|
nl/toolforge/karma/core/cmd/impl/ExitCleanCommand.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
37
|
|
| Missing a Javadoc comment. |
39
|
|
| Variable 'response' must be private and have accessor methods. |
39
|
|
| Parameter descriptor should be final. |
45
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
49
|
|
| Missing a Javadoc comment. |
49
|
|
| Line contains a tab character. |
51
|
|
| Line contains a tab character. |
53
|
|
| '+' is not preceded with whitespace. |
53
|
|
| '+' is not followed by whitespace. |
53
|
|
| Line contains a tab character. |
54
|
|
| Method 'getCommandResponse' is not designed for extension - needs to be abstract, final or empty. |
57
|
|
| Missing a Javadoc comment. |
57
|
nl/toolforge/karma/core/cmd/impl/GenerateTestReport.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
39
|
|
| Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
39
|
|
| Missing a Javadoc comment. |
41
|
|
| Missing a Javadoc comment. |
43
|
|
| Parameter descriptor should be final. |
43
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
47
|
|
| Missing a Javadoc comment. |
47
|
|
| '+' is not preceded with whitespace. |
55
|
|
| '+' is not preceded with whitespace. |
56
|
|
| Expected an @return tag. |
71
|
|
| Method 'getCommandResponse' is not designed for extension - needs to be abstract, final or empty. |
71
|
nl/toolforge/karma/core/cmd/impl/ListManifests.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
nl/toolforge/karma/core/cmd/impl/ListManifests.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
44
|
|
| Parameter descriptor should be final. |
51
|
|
| Expected @param tag for 'descriptor'. |
51
|
|
| Method 'getCommandResponse' is not designed for extension - needs to be abstract, final or empty. |
60
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
69
|
|
| Expected @throws tag for 'CommandException'. |
69
|
|
| Method 'getHeaders' is not designed for extension - needs to be abstract, final or empty. |
105
|
|
| Missing a Javadoc comment. |
109
|
nl/toolforge/karma/core/cmd/impl/PackageModule.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
72
|
|
| Missing a Javadoc comment. |
74
|
|
| Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
74
|
|
| Missing a Javadoc comment. |
76
|
|
| Missing a Javadoc comment. |
78
|
|
| Parameter descriptor should be final. |
78
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
82
|
|
| Method length is 157 lines (max allowed is 150). |
82
|
|
| Missing a Javadoc comment. |
82
|
|
| Line is longer than 120 characters. |
106
|
|
| '+' is not preceded with whitespace. |
114
|
|
| '+' is not followed by whitespace. |
114
|
|
| '(' is followed by whitespace. |
124
|
|
| ')' is preceded with whitespace. |
124
|
|
| '(' is followed by whitespace. |
148
|
|
| '!' is followed by whitespace. |
148
|
|
| ')' is preceded with whitespace. |
148
|
|
| '(' is followed by whitespace. |
175
|
|
| ')' is preceded with whitespace. |
175
|
|
| '+' is not preceded with whitespace. |
186
|
|
| '+' is not followed by whitespace. |
186
|
|
| '||' should be on a new line. |
192
|
|
| '||' should be on a new line. |
193
|
|
| ')' is preceded with whitespace. |
194
|
|
| Must have at least one statement. |
197
|
|
| '(' is followed by whitespace. |
205
|
|
| ')' is preceded with whitespace. |
205
|
|
| Missing a Javadoc comment. |
240
|
|
| Parameter packageName should be final. |
240
|
|
| Missing a Javadoc comment. |
291
|
|
| Parameter packageName should be final. |
291
|
|
| Missing a Javadoc comment. |
392
|
|
| Parameter packageName should be final. |
392
|
|
| ',' is not followed by whitespace. |
439
|
|
| Line is longer than 120 characters. |
467
|
|
| Method length is 151 lines (max allowed is 150). |
488
|
|
| Missing a Javadoc comment. |
488
|
|
| Parameter packageName should be final. |
488
|
|
| Line is longer than 120 characters. |
511
|
|
| ';' is followed by whitespace. |
518
|
|
| '+' is not preceded with whitespace. |
520
|
|
| '+' is not followed by whitespace. |
520
|
|
| '+' is not preceded with whitespace. |
520
|
|
| '+' is not followed by whitespace. |
520
|
|
| Must have at least one statement. |
537
|
|
| Line is longer than 120 characters. |
560
|
|
| Line is longer than 120 characters. |
622
|
|
| Method 'getCommandResponse' is not designed for extension - needs to be abstract, final or empty. |
645
|
nl/toolforge/karma/core/cmd/impl/PromoteCommand.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
53
|
|
| Missing a Javadoc comment. |
54
|
|
| Variable 'commandResponse' must be private and have accessor methods. |
54
|
|
| Missing a Javadoc comment. |
56
|
|
| Parameter descriptor should be final. |
56
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
64
|
|
| Line is longer than 120 characters. |
94
|
|
| Line is longer than 120 characters. |
96
|
|
| Line is longer than 120 characters. |
102
|
|
| Line is longer than 120 characters. |
104
|
|
| Line is longer than 120 characters. |
110
|
|
| Line is longer than 120 characters. |
112
|
|
| '!' is followed by whitespace. |
124
|
|
| Line is longer than 120 characters. |
125
|
|
| Method 'getCommandResponse' is not designed for extension - needs to be abstract, final or empty. |
167
|
nl/toolforge/karma/core/cmd/impl/SelectManifest.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
45
|
|
| Missing a Javadoc comment. |
47
|
|
| Missing a Javadoc comment. |
48
|
|
| Missing a Javadoc comment. |
50
|
|
| Parameter descriptor should be final. |
50
|
|
| Line contains a tab character. |
56
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
57
|
|
| Expected @throws tag for 'CommandException'. |
57
|
|
| Method 'getCommandResponse' is not designed for extension - needs to be abstract, final or empty. |
87
|
|
| Method 'getSelectedManifest' is not designed for extension - needs to be abstract, final or empty. |
91
|
|
| Missing a Javadoc comment. |
91
|
nl/toolforge/karma/core/cmd/impl/StartWorkCommand.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
50
|
|
| Missing a Javadoc comment. |
52
|
|
| Variable 'response' must be private and have accessor methods. |
52
|
|
| Parameter descriptor should be final. |
58
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
62
|
|
| Missing a Javadoc comment. |
62
|
|
| Line is longer than 120 characters. |
95
|
|
| Line is longer than 120 characters. |
96
|
|
| Line is longer than 120 characters. |
104
|
|
| Line is longer than 120 characters. |
114
|
|
| Line is longer than 120 characters. |
155
|
|
| Line is longer than 120 characters. |
177
|
|
| Method 'getCommandResponse' is not designed for extension - needs to be abstract, final or empty. |
192
|
nl/toolforge/karma/core/cmd/impl/StopWorkCommand.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
52
|
|
| Variable 'response' must be private and have accessor methods. |
52
|
|
| Parameter descriptor should be final. |
57
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
61
|
|
| Missing a Javadoc comment. |
61
|
|
| Must have at least one statement. |
97
|
|
| '{' is not followed by whitespace. |
97
|
|
| '}' is not preceded with whitespace. |
97
|
|
| Must have at least one statement. |
107
|
|
| '{' is not followed by whitespace. |
107
|
|
| '}' is not preceded with whitespace. |
107
|
|
| Must have at least one statement. |
117
|
|
| '{' is not followed by whitespace. |
117
|
|
| '}' is not preceded with whitespace. |
117
|
|
| Method 'getCommandResponse' is not designed for extension - needs to be abstract, final or empty. |
162
|
nl/toolforge/karma/core/cmd/impl/TestAllModules.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
34
|
|
| Parameter descriptor should be final. |
34
|
|
| Missing a Javadoc comment. |
38
|
|
| Method 'getCommandResponse' is not designed for extension - needs to be abstract, final or empty. |
47
|
nl/toolforge/karma/core/cmd/impl/TestModule.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
53
|
|
| Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
53
|
|
| Missing a Javadoc comment. |
55
|
|
| Missing a Javadoc comment. |
57
|
|
| Parameter descriptor should be final. |
57
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
61
|
|
| Missing a Javadoc comment. |
61
|
|
| '+' is not preceded with whitespace. |
73
|
|
| '+' is not followed by whitespace. |
73
|
|
| '||' should be on a new line. |
79
|
|
| '||' should be on a new line. |
80
|
|
| ')' is preceded with whitespace. |
81
|
|
| Must have at least one statement. |
84
|
|
| '(' is followed by whitespace. |
93
|
|
| ')' is preceded with whitespace. |
93
|
|
| Line is longer than 120 characters. |
113
|
|
| '+' is not preceded with whitespace. |
120
|
|
| '+' is not followed by whitespace. |
120
|
|
| '+' is not preceded with whitespace. |
121
|
|
| '+' is not followed by whitespace. |
121
|
|
| '+' is not preceded with whitespace. |
127
|
|
| '+' is not followed by whitespace. |
127
|
|
| '+' is not preceded with whitespace. |
143
|
|
| '+' is not followed by whitespace. |
143
|
|
| Line is longer than 120 characters. |
159
|
|
| Method 'getCommandResponse' is not designed for extension - needs to be abstract, final or empty. |
167
|
nl/toolforge/karma/core/cmd/impl/UpdateAdmin.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
44
|
|
| Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
44
|
|
| Missing a Javadoc comment. |
46
|
|
| Missing a Javadoc comment. |
48
|
|
| Parameter descriptor should be final. |
48
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
52
|
|
| Missing a Javadoc comment. |
52
|
|
| Method 'getCommandResponse' is not designed for extension - needs to be abstract, final or empty. |
84
|
|
| Missing a Javadoc comment. |
84
|
nl/toolforge/karma/core/cmd/impl/UpdateAllModulesCommand.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
47
|
|
| Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
47
|
|
| Method 'getCommandResponse' is not designed for extension - needs to be abstract, final or empty. |
54
|
|
| Missing a Javadoc comment. |
58
|
|
| Parameter descriptor should be final. |
65
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
74
|
|
| Expected @throws tag for 'CommandException'. |
74
|
nl/toolforge/karma/core/cmd/impl/UpdateModuleCommand.java
| Error | Line |
|---|
|
| Unclosed HTML tag found: <pre>update-module -m, --module-name <module-name> [ - |
45
|
|
| Missing a Javadoc comment. |
58
|
|
| Variable 'response' must be private and have accessor methods. |
58
|
|
| Parameter descriptor should be final. |
66
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
75
|
|
| Expected @throws tag for 'CommandException'. |
75
|
|
| ',' is not followed by whitespace. |
92
|
|
| Line is longer than 120 characters. |
133
|
|
| Line is longer than 120 characters. |
140
|
|
| Line is longer than 120 characters. |
148
|
|
| Line is longer than 120 characters. |
168
|
|
| Line is longer than 120 characters. |
176
|
|
| Method 'getCommandResponse' is not designed for extension - needs to be abstract, final or empty. |
189
|
|
| Missing a Javadoc comment. |
189
|
nl/toolforge/karma/core/cmd/impl/ViewManifest.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
51
|
|
| Variable 'logger' must be private and have accessor methods. |
51
|
|
| Missing a Javadoc comment. |
53
|
|
| Missing a Javadoc comment. |
54
|
|
| Missing a Javadoc comment. |
56
|
|
| Parameter descriptor should be final. |
56
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
62
|
|
| Missing a Javadoc comment. |
62
|
|
| '8' is a magic number. |
95
|
|
| Avoid inline conditionals. |
122
|
|
| '3' is a magic number. |
128
|
|
| Avoid inline conditionals. |
128
|
|
| '3' is a magic number. |
130
|
|
| '4' is a magic number. |
139
|
|
| '(' is followed by whitespace. |
140
|
|
| '4' is a magic number. |
140
|
|
| ')' is preceded with whitespace. |
140
|
|
| '4' is a magic number. |
141
|
|
| '5' is a magic number. |
143
|
|
| Avoid inline conditionals. |
143
|
|
| '6' is a magic number. |
146
|
|
| '7' is a magic number. |
147
|
|
| '6' is a magic number. |
149
|
|
| '7' is a magic number. |
151
|
|
| '7' is a magic number. |
153
|
|
| '7' is a magic number. |
155
|
|
| '7' is a magic number. |
157
|
|
| Method 'getCommandResponse' is not designed for extension - needs to be abstract, final or empty. |
169
|
|
| Method 'getData' is not designed for extension - needs to be abstract, final or empty. |
180
|
nl/toolforge/karma/core/cmd/impl/ViewWorkingContexts.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
nl/toolforge/karma/core/cmd/impl/ViewWorkingContexts.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'Karma core - Core of the Karma application'. |
2
|
|
| First sentence should end with a period. |
32
|
|
| Missing a Javadoc comment. |
41
|
|
| Missing a Javadoc comment. |
43
|
|
| Missing a Javadoc comment. |
45
|
|
| Parameter descriptor should be final. |
45
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
49
|
|
| Missing a Javadoc comment. |
49
|
|
| Method 'getWorkingContexts' is not designed for extension - needs to be abstract, final or empty. |
72
|
|
| Missing a Javadoc comment. |
72
|
|
| Method 'getCommandResponse' is not designed for extension - needs to be abstract, final or empty. |
76
|
|
| Missing a Javadoc comment. |
76
|
nl/toolforge/karma/core/cmd/impl/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
nl/toolforge/karma/core/cmd/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
nl/toolforge/karma/core/cmd/threads/ParallelCommandWrapper.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
35
|
|
| Missing a Javadoc comment. |
37
|
|
| Missing a Javadoc comment. |
38
|
|
| Missing a Javadoc comment. |
39
|
|
| Missing a Javadoc comment. |
41
|
|
| Parameter command should be final. |
41
|
|
| 'command' hides a field. |
41
|
|
| Parameter listener should be final. |
41
|
|
| 'listener' hides a field. |
41
|
|
| Missing a Javadoc comment. |
46
|
|
| Missing a Javadoc comment. |
50
|
|
| Missing a Javadoc comment. |
65
|
|
| Missing a Javadoc comment. |
71
|
|
| Missing a Javadoc comment. |
79
|
nl/toolforge/karma/core/cmd/threads/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
nl/toolforge/karma/core/cmd/util/AntLogger.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
37
|
|
| Missing a Javadoc comment. |
41
|
|
| Missing a Javadoc comment. |
45
|
|
| Missing a Javadoc comment. |
47
|
|
| Missing a Javadoc comment. |
62
|
|
| Parameter command should be final. |
62
|
|
| 'command' hides a field. |
62
|
|
| Missing a Javadoc comment. |
66
|
|
| Parameter event should be final. |
66
|
|
| Method 'messageLogged' is not designed for extension - needs to be abstract, final or empty. |
87
|
|
| Parameter event should be final. |
87
|
|
| Expected @param tag for 'event'. |
87
|
|
| Parameter event should be final. |
103
|
|
| Expected @param tag for 'event'. |
103
|
|
| '{' is not followed by whitespace. |
103
|
|
| '}' is not preceded with whitespace. |
103
|
nl/toolforge/karma/core/cmd/util/ApplicationXml.java
| Error | Line |
|---|
|
| Line has trailing spaces. |
23
|
nl/toolforge/karma/core/cmd/util/BuildEnvironment.java
| Error | Line |
|---|
|
| First sentence should end with a period. |
26
|
|
| Missing a Javadoc comment. |
34
|
|
| Missing a Javadoc comment. |
35
|
|
| Missing a Javadoc comment. |
37
|
|
| Parameter manifest should be final. |
37
|
|
| 'manifest' hides a field. |
37
|
|
| Parameter module should be final. |
37
|
|
| 'module' hides a field. |
37
|
|
| Expected an @return tag. |
45
|
|
| Method 'getBuildRootDirectory' is not designed for extension - needs to be abstract, final or empty. |
45
|
|
| Expected an @return tag. |
55
|
|
| Method 'getModuleBuildRootDirectory' is not designed for extension - needs to be abstract, final or empty. |
55
|
|
| Expected an @return tag. |
64
|
|
| Method 'getModuleBuildDirectory' is not designed for extension - needs to be abstract, final or empty. |
64
|
|
| Expected an @return tag. |
73
|
|
| Method 'getModuleTestBuildDirectory' is not designed for extension - needs to be abstract, final or empty. |
73
|
|
| Method 'getModuleJavadocDirectory' is not designed for extension - needs to be abstract, final or empty. |
77
|
|
| Missing a Javadoc comment. |
77
|
|
| Method 'getModulePackageDirectory' is not designed for extension - needs to be abstract, final or empty. |
81
|
|
| Missing a Javadoc comment. |
81
|
|
| Method 'getModuleSourceDirectory' is not designed for extension - needs to be abstract, final or empty. |
85
|
|
| Missing a Javadoc comment. |
85
|
|
| Method 'getModuleTestSourceDirectory' is not designed for extension - needs to be abstract, final or empty. |
89
|
|
| Missing a Javadoc comment. |
89
|
|
| Expected an @return tag. |
96
|
|
| Method 'getManifestBuildDirectory' is not designed for extension - needs to be abstract, final or empty. |
96
|
nl/toolforge/karma/core/cmd/util/BuildUtil.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
45
|
|
| Missing a Javadoc comment. |
47
|
|
| Parameter currentManifest should be final. |
47
|
|
| 'currentManifest' hides a field. |
47
|
|
| Unused @param tag for 'modules'. |
56
|
|
| Parameter module should be final. |
58
|
|
| Expected @throws tag for 'ManifestException'. |
58
|
nl/toolforge/karma/core/cmd/util/DependencyException.java
| Error | Line |
|---|
|
| First sentence should end with a period. |
23
|
|
| Missing a Javadoc comment. |
31
|
|
| Missing a Javadoc comment. |
32
|
|
| Missing a Javadoc comment. |
34
|
|
| First sentence should end with a period. |
41
|
|
| Line has trailing spaces. |
41
|
|
| Missing a Javadoc comment. |
44
|
|
| Missing a Javadoc comment. |
45
|
|
| Missing a Javadoc comment. |
46
|
|
| Missing a Javadoc comment. |
48
|
|
| Parameter errorCode should be final. |
48
|
|
| 'errorCode' hides a field. |
48
|
|
| Missing a Javadoc comment. |
52
|
|
| Parameter errorCode should be final. |
52
|
|
| 'errorCode' hides a field. |
52
|
|
| Parameter messageArguments should be final. |
52
|
|
| 'messageArguments' hides a field. |
52
|
|
| Missing a Javadoc comment. |
58
|
|
| Parameter t should be final. |
58
|
|
| Parameter errorCode should be final. |
58
|
|
| 'errorCode' hides a field. |
58
|
|
| Parameter messageArguments should be final. |
58
|
|
| 'messageArguments' hides a field. |
58
|
|
| Method 'getMessage' is not designed for extension - needs to be abstract, final or empty. |
64
|
|
| Missing a Javadoc comment. |
64
|
|
| Expected an @return tag. |
75
|
|
| Missing a Javadoc comment. |
79
|
nl/toolforge/karma/core/cmd/util/DependencyHelper.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
50
|
|
| 'static' modifier out of order with the JLS suggestions. |
50
|
|
| Missing a Javadoc comment. |
52
|
|
| Missing a Javadoc comment. |
54
|
|
| Parameter currentManifest should be final. |
54
|
|
| Parameter module should be final. |
69
|
|
| Expected @throws tag for 'ModuleTypeException'. |
69
|
|
| Expected @throws tag for 'DependencyException'. |
69
|
|
| Parameter module should be final. |
88
|
|
| Expected @throws tag for 'ModuleTypeException'. |
88
|
|
| Expected @throws tag for 'DependencyException'. |
88
|
|
| Line is longer than 120 characters. |
94
|
|
| Missing a Javadoc comment. |
94
|
|
| Parameter module should be final. |
94
|
|
| Parameter doTest should be final. |
94
|
|
| Parameter doPackage should be final. |
94
|
|
| Line is longer than 120 characters. |
113
|
|
| Parameter module should be final. |
113
|
|
| Parameter doTest should be final. |
113
|
|
| Parameter doPackage should be final. |
113
|
|
| Parameter moduleType should be final. |
113
|
|
| Expected @throws tag for 'ModuleTypeException'. |
113
|
|
| Line is longer than 120 characters. |
132
|
|
| '&&' should be on a new line. |
136
|
|
| ')' is preceded with whitespace. |
137
|
|
| '&&' should be on a new line. |
146
|
|
| ')' is preceded with whitespace. |
147
|
|
| ')' is preceded with whitespace. |
156
|
|
| '&&' should be on a new line. |
159
|
|
| Line is longer than 120 characters. |
161
|
|
| Line is longer than 120 characters. |
165
|
|
| Line is longer than 120 characters. |
196
|
|
| Parameter module should be final. |
196
|
|
| Parameter doTest should be final. |
196
|
|
| Parameter doPackage should be final. |
196
|
|
| Expected @throws tag for 'ModuleTypeException'. |
196
|
|
| Parameter module should be final. |
208
|
|
| Expected @param tag for 'module'. |
208
|
|
| Expected @throws tag for 'DependencyException'. |
208
|
|
| '+' is not preceded with whitespace. |
227
|
|
| '+' is not followed by whitespace. |
227
|
|
| '+' is not preceded with whitespace. |
227
|
|
| '+' is not followed by whitespace. |
227
|
|
| '+' is not preceded with whitespace. |
227
|
|
| '+' is not followed by whitespace. |
227
|
|
| Parameter module should be final. |
251
|
|
| Parameter dependency should be final. |
251
|
|
| Parameter doPackage should be final. |
251
|
|
| Line is longer than 120 characters. |
270
|
|
| Parameter module should be final. |
285
|
|
| Parameter doPackage should be final. |
285
|
|
| Parameter module should be final. |
335
|
|
| Expected @throws tag for 'DependencyException'. |
335
|
|
| Parameter module should be final. |
377
|
|
| Expected @throws tag for 'ModuleTypeException'. |
377
|
|
| Expected @throws tag for 'DependencyException'. |
377
|
|
| Parameter module should be final. |
406
|
|
| Expected @param tag for 'module'. |
406
|
|
| Expected @throws tag for 'ManifestException'. |
406
|
|
| Expected @throws tag for 'DependencyException'. |
406
|
|
| Missing a Javadoc comment. |
412
|
|
| Parameter module should be final. |
412
|
|
| Parameter currentSet should be final. |
412
|
|
| '{' is not preceded with whitespace. |
412
|
|
| Must have at least one statement. |
425
|
nl/toolforge/karma/core/cmd/util/DependencyPath.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
34
|
|
| Missing a Javadoc comment. |
35
|
|
| First sentence should end with a period. |
37
|
|
| Parameter pathPrefix should be final. |
43
|
|
| 'pathPrefix' hides a field. |
43
|
|
| Parameter relativePath should be final. |
43
|
|
| 'relativePath' hides a field. |
43
|
|
| Method 'getPathPrefix' is not designed for extension - needs to be abstract, final or empty. |
48
|
|
| Missing a Javadoc comment. |
48
|
|
| Method 'getRelativePath' is not designed for extension - needs to be abstract, final or empty. |
52
|
|
| Missing a Javadoc comment. |
52
|
|
| Method 'getFullPath' is not designed for extension - needs to be abstract, final or empty. |
62
|
|
| Method 'exists' is not designed for extension - needs to be abstract, final or empty. |
71
|
|
| Parameter dependencyPaths should be final. |
83
|
|
| Parameter relative should be final. |
83
|
|
| Parameter separator should be final. |
83
|
|
| Line has trailing spaces. |
99
|
nl/toolforge/karma/core/cmd/util/DescriptorReader.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
40
|
|
| Missing a Javadoc comment. |
52
|
|
| Parameter descriptor should be final. |
58
|
|
| 'descriptor' hides a field. |
58
|
|
| Method 'getApplicationXmlDescriptor' is not designed for extension - needs to be abstract, final or empty. |
67
|
|
| Missing a Javadoc comment. |
67
|
|
| Method 'parse' is not designed for extension - needs to be abstract, final or empty. |
71
|
|
| Missing a Javadoc comment. |
71
|
|
| Parameter baseDir should be final. |
71
|
|
| Missing a Javadoc comment. |
80
|
|
| Parameter baseDir should be final. |
80
|
|
| Missing a Javadoc comment. |
84
|
|
| Parameter baseDir should be final. |
84
|
|
| Missing a Javadoc comment. |
104
|
|
| Expected an @return tag. |
112
|
|
| Method 'getModuleNames' is not designed for extension - needs to be abstract, final or empty. |
112
|
nl/toolforge/karma/core/cmd/util/KarmaBuildException.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
31
|
|
| Parameter t should be final. |
31
|
|
| Missing a Javadoc comment. |
35
|
|
| Parameter t should be final. |
35
|
|
| Missing a Javadoc comment. |
39
|
|
| Parameter r should be final. |
39
|
nl/toolforge/karma/core/cmd/util/WebXml.java
| Error | Line |
|---|
|
| Line has trailing spaces. |
24
|
nl/toolforge/karma/core/cmd/util/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
nl/toolforge/karma/core/history/ModuleHistory.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
43
|
|
| Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
43
|
|
| Missing a Javadoc comment. |
45
|
|
| 'static' modifier out of order with the JLS suggestions. |
45
|
|
| Missing a Javadoc comment. |
47
|
|
| Missing a Javadoc comment. |
48
|
|
| Missing a Javadoc comment. |
50
|
|
| Method 'addEvent' is not designed for extension - needs to be abstract, final or empty. |
53
|
|
| Missing a Javadoc comment. |
53
|
|
| Parameter moduleHistoryEvent should be final. |
53
|
|
| Method 'getEvents' is not designed for extension - needs to be abstract, final or empty. |
64
|
|
| Method 'setHistoryLocation' is not designed for extension - needs to be abstract, final or empty. |
68
|
|
| Missing a Javadoc comment. |
68
|
|
| Parameter historyLocation should be final. |
68
|
|
| 'historyLocation' hides a field. |
68
|
|
| Method 'getHistoryLocation' is not designed for extension - needs to be abstract, final or empty. |
72
|
|
| Missing a Javadoc comment. |
72
|
|
| Method 'save' is not designed for extension - needs to be abstract, final or empty. |
76
|
|
| Missing a Javadoc comment. |
76
|
|
| ';' is followed by whitespace. |
81
|
|
| Must have at least one statement. |
104
|
|
| '(' is followed by whitespace. |
110
|
|
| ')' is preceded with whitespace. |
110
|
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
119
|
|
| Missing a Javadoc comment. |
119
|
|
| '+' is not preceded with whitespace. |
120
|
|
| '+' is not followed by whitespace. |
120
|
|
| '+' is not preceded with whitespace. |
120
|
|
| '+' is not followed by whitespace. |
120
|
nl/toolforge/karma/core/history/ModuleHistoryEvent.java
| Error | Line |
|---|
|
| First sentence should end with a period. |
34
|
|
| 'static' modifier out of order with the JLS suggestions. |
37
|
|
| First sentence should end with a period. |
39
|
|
| 'static' modifier out of order with the JLS suggestions. |
42
|
|
| First sentence should end with a period. |
44
|
|
| 'static' modifier out of order with the JLS suggestions. |
47
|
|
| Missing a Javadoc comment. |
49
|
|
| Missing a Javadoc comment. |
50
|
|
| Missing a Javadoc comment. |
51
|
|
| Missing a Javadoc comment. |
52
|
|
| Missing a Javadoc comment. |
53
|
|
| Missing a Javadoc comment. |
55
|
|
| Method 'setType' is not designed for extension - needs to be abstract, final or empty. |
58
|
|
| Missing a Javadoc comment. |
58
|
|
| Parameter type should be final. |
58
|
|
| 'type' hides a field. |
58
|
|
| Method 'setVersion' is not designed for extension - needs to be abstract, final or empty. |
62
|
|
| Missing a Javadoc comment. |
62
|
|
| Parameter version should be final. |
62
|
|
| 'version' hides a field. |
62
|
|
| Method 'setDatetime' is not designed for extension - needs to be abstract, final or empty. |
66
|
|
| Missing a Javadoc comment. |
66
|
|
| Parameter datetime should be final. |
66
|
|
| 'datetime' hides a field. |
66
|
|
| Method 'setAuthor' is not designed for extension - needs to be abstract, final or empty. |
70
|
|
| Missing a Javadoc comment. |
70
|
|
| Parameter author should be final. |
70
|
|
| 'author' hides a field. |
70
|
|
| Method 'setComment' is not designed for extension - needs to be abstract, final or empty. |
78
|
|
| Missing a Javadoc comment. |
78
|
|
| Parameter comment should be final. |
78
|
|
| 'comment' hides a field. |
78
|
|
| Method 'getType' is not designed for extension - needs to be abstract, final or empty. |
83
|
|
| Missing a Javadoc comment. |
83
|
|
| Method 'getVersion' is not designed for extension - needs to be abstract, final or empty. |
87
|
|
| Missing a Javadoc comment. |
87
|
|
| Method 'getDatetime' is not designed for extension - needs to be abstract, final or empty. |
91
|
|
| Missing a Javadoc comment. |
91
|
|
| Method 'getAuthor' is not designed for extension - needs to be abstract, final or empty. |
95
|
|
| Missing a Javadoc comment. |
95
|
|
| Method 'getComment' is not designed for extension - needs to be abstract, final or empty. |
99
|
|
| Missing a Javadoc comment. |
99
|
|
| Method 'toXml' is not designed for extension - needs to be abstract, final or empty. |
103
|
|
| Missing a Javadoc comment. |
103
|
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
116
|
|
| Missing a Javadoc comment. |
116
|
nl/toolforge/karma/core/history/ModuleHistoryException.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
31
|
|
| Missing a Javadoc comment. |
32
|
|
| Missing a Javadoc comment. |
54
|
|
| Parameter errorCode should be final. |
54
|
|
| 'errorCode' hides a field. |
54
|
|
| Missing a Javadoc comment. |
58
|
|
| Parameter t should be final. |
58
|
|
| Parameter errorCode should be final. |
58
|
|
| 'errorCode' hides a field. |
58
|
|
| Missing a Javadoc comment. |
62
|
|
| Parameter errorCode should be final. |
62
|
|
| 'errorCode' hides a field. |
62
|
|
| Parameter messageArguments should be final. |
62
|
|
| 'messageArguments' hides a field. |
62
|
|
| Missing a Javadoc comment. |
68
|
|
| Parameter t should be final. |
68
|
|
| Parameter errorCode should be final. |
68
|
|
| 'errorCode' hides a field. |
68
|
|
| Parameter messageArguments should be final. |
68
|
|
| 'messageArguments' hides a field. |
68
|
|
| Method 'getMessage' is not designed for extension - needs to be abstract, final or empty. |
74
|
|
| Missing a Javadoc comment. |
74
|
|
| Expected an @return tag. |
84
|
|
| Expected an @return tag. |
91
|
nl/toolforge/karma/core/history/ModuleHistoryFactory.java
| Error | Line |
|---|
|
| Class ModuleHistoryFactory should be declared as final. |
37
|
|
| Missing a Javadoc comment. |
39
|
|
| Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
39
|
|
| Missing a Javadoc comment. |
40
|
|
| Missing a Javadoc comment. |
42
|
|
| Missing a Javadoc comment. |
44
|
|
| Parameter manifestHome should be final. |
44
|
|
| 'manifestHome' hides a field. |
44
|
|
| Parameter manifestHome should be final. |
54
|
|
| 'manifestHome' hides a field. |
54
|
|
| '(' is followed by whitespace. |
55
|
|
| '+' is not preceded with whitespace. |
56
|
|
| '+' is not followed by whitespace. |
56
|
|
| Parameter module should be final. |
69
|
|
| Expected @throws tag for 'ModuleHistoryException'. |
69
|
|
| Line is longer than 120 characters. |
100
|
nl/toolforge/karma/core/location/BaseLocation.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
32
|
|
| Missing a Javadoc comment. |
33
|
|
| Missing a Javadoc comment. |
34
|
|
| Parameter id should be final. |
42
|
|
| 'id' hides a field. |
42
|
|
| Parameter type should be final. |
42
|
|
| 'type' hides a field. |
42
|
|
| Missing a Javadoc comment. |
54
|
|
| Missing a Javadoc comment. |
58
|
|
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
62
|
|
| Missing a Javadoc comment. |
62
|
|
| Parameter obj should be final. |
62
|
|
| Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. |
72
|
|
| Missing a Javadoc comment. |
72
|
|
| Missing a Javadoc comment. |
78
|
|
| Parameter workingContext should be final. |
78
|
|
| 'workingContext' hides a field. |
78
|
|
| Method 'getAuthenticatorKey' is not designed for extension - needs to be abstract, final or empty. |
82
|
|
| Missing a Javadoc comment. |
82
|
nl/toolforge/karma/core/location/Location.java
| Error | Line |
|---|
|
| Redundant 'public' modifier. |
42
|
|
| Redundant 'public' modifier. |
49
|
|
| Line is longer than 120 characters. |
54
|
|
| Redundant 'public' modifier. |
58
|
|
| Expected an @return tag. |
63
|
|
| Redundant 'public' modifier. |
63
|
|
| Redundant 'public' modifier. |
70
|
|
| Expected @throws tag for 'AuthenticationException'. |
70
|
|
| Missing a Javadoc comment. |
72
|
|
| Redundant 'public' modifier. |
72
|
|
| Missing a Javadoc comment. |
74
|
|
| Redundant 'public' modifier. |
74
|
nl/toolforge/karma/core/location/LocationDescriptor.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
33
|
|
| Missing a Javadoc comment. |
34
|
|
| Missing a Javadoc comment. |
36
|
|
| Missing a Javadoc comment. |
37
|
|
| Missing a Javadoc comment. |
38
|
|
| Missing a Javadoc comment. |
39
|
|
| Missing a Javadoc comment. |
40
|
|
| Method 'getId' is not designed for extension - needs to be abstract, final or empty. |
42
|
|
| Missing a Javadoc comment. |
42
|
|
| Method 'setId' is not designed for extension - needs to be abstract, final or empty. |
46
|
|
| Missing a Javadoc comment. |
46
|
|
| Parameter id should be final. |
46
|
|
| 'id' hides a field. |
46
|
|
| Method 'getType' is not designed for extension - needs to be abstract, final or empty. |
50
|
|
| Missing a Javadoc comment. |
50
|
|
| Method 'setType' is not designed for extension - needs to be abstract, final or empty. |
54
|
|
| Missing a Javadoc comment. |
54
|
|
| Parameter type should be final. |
54
|
|
| 'type' hides a field. |
54
|
|
| Method 'getHost' is not designed for extension - needs to be abstract, final or empty. |
58
|
|
| Missing a Javadoc comment. |
58
|
|
| Method 'setHost' is not designed for extension - needs to be abstract, final or empty. |
62
|
|
| Missing a Javadoc comment. |
62
|
|
| Parameter host should be final. |
62
|
|
| 'host' hides a field. |
62
|
|
| Method 'getPort' is not designed for extension - needs to be abstract, final or empty. |
66
|
|
| Missing a Javadoc comment. |
66
|
|
| Method 'setPort' is not designed for extension - needs to be abstract, final or empty. |
70
|
|
| Missing a Javadoc comment. |
70
|
|
| Parameter port should be final. |
70
|
|
| 'port' hides a field. |
70
|
|
| Method 'getRepository' is not designed for extension - needs to be abstract, final or empty. |
74
|
|
| Missing a Javadoc comment. |
74
|
|
| Method 'setRepository' is not designed for extension - needs to be abstract, final or empty. |
78
|
|
| Missing a Javadoc comment. |
78
|
|
| Parameter repository should be final. |
78
|
|
| 'repository' hides a field. |
78
|
|
| Method 'getModuleOffset' is not designed for extension - needs to be abstract, final or empty. |
82
|
|
| Missing a Javadoc comment. |
82
|
|
| Method 'setModuleOffset' is not designed for extension - needs to be abstract, final or empty. |
86
|
|
| Missing a Javadoc comment. |
86
|
|
| Parameter moduleOffset should be final. |
86
|
|
| 'moduleOffset' hides a field. |
86
|
|
| Method 'getProtocol' is not designed for extension - needs to be abstract, final or empty. |
90
|
|
| Missing a Javadoc comment. |
90
|
|
| Method 'setProtocol' is not designed for extension - needs to be abstract, final or empty. |
94
|
|
| Missing a Javadoc comment. |
94
|
|
| Parameter protocol should be final. |
94
|
|
| 'protocol' hides a field. |
94
|
|
| Line has trailing spaces. |
111
|
nl/toolforge/karma/core/location/LocationException.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
32
|
|
| Missing a Javadoc comment. |
33
|
|
| First sentence should end with a period. |
52
|
|
| Missing a Javadoc comment. |
65
|
|
| Line has trailing spaces. |
91
|
|
| Missing a Javadoc comment. |
92
|
|
| Missing a Javadoc comment. |
95
|
|
| Parameter errorCode should be final. |
95
|
|
| 'errorCode' hides a field. |
95
|
|
| Missing a Javadoc comment. |
99
|
|
| Parameter t should be final. |
99
|
|
| Parameter errorCode should be final. |
99
|
|
| 'errorCode' hides a field. |
99
|
|
| Missing a Javadoc comment. |
103
|
|
| Parameter errorCode should be final. |
103
|
|
| 'errorCode' hides a field. |
103
|
|
| Parameter messageArguments should be final. |
103
|
|
| 'messageArguments' hides a field. |
103
|
|
| Missing a Javadoc comment. |
109
|
|
| Parameter t should be final. |
109
|
|
| Parameter errorCode should be final. |
109
|
|
| 'errorCode' hides a field. |
109
|
|
| Parameter messageArguments should be final. |
109
|
|
| 'messageArguments' hides a field. |
109
|
|
| Expected an @return tag. |
125
|
|
| Expected an @return tag. |
135
|
|
| Redundant 'final' modifier. |
135
|
|
| Expected an @return tag. |
142
|
|
| Redundant 'final' modifier. |
142
|
nl/toolforge/karma/core/location/LocationFactory.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'Karma core - Core of the Karma application'. |
2
|
|
| Class LocationFactory should be declared as final. |
12
|
|
| Missing a Javadoc comment. |
12
|
|
| Missing a Javadoc comment. |
14
|
|
| Missing a Javadoc comment. |
15
|
|
| Expected an @return tag. |
20
|
|
| Missing a Javadoc comment. |
28
|
|
| Missing a Javadoc comment. |
30
|
|
| Parameter descriptor should be final. |
30
|
|
| Line is longer than 120 characters. |
36
|
|
| Line is longer than 120 characters. |
106
|
|
| '+' is not preceded with whitespace. |
106
|
|
| '+' is not followed by whitespace. |
106
|
|
| '+' is not preceded with whitespace. |
106
|
|
| '+' is not followed by whitespace. |
106
|
|
| '+' is not preceded with whitespace. |
106
|
|
| '+' is not followed by whitespace. |
106
|
|
| '+' is not preceded with whitespace. |
106
|
|
| '+' is not followed by whitespace. |
106
|
nl/toolforge/karma/core/location/LocationLoader.java
| Error | Line |
|---|
|
| Line is longer than 120 characters. |
34
|
|
| Missing a Javadoc comment. |
48
|
|
| Missing a Javadoc comment. |
49
|
|
| Parameter workingContext should be final. |
55
|
|
| 'workingContext' hides a field. |
55
|
|
| Expected @param tag for 'workingContext'. |
55
|
|
| Expected @throws tag for 'LocationException'. |
69
|
|
| Line has trailing spaces. |
117
|
|
| Redundant 'final' modifier. |
129
|
|
| Redundant 'final' modifier. |
143
|
|
| Parameter locationAlias should be final. |
143
|
nl/toolforge/karma/core/location/LocationType.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
nl/toolforge/karma/core/location/LocationType.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'Karma core - Core of the Karma application'. |
2
|
|
| First sentence should end with a period. |
13
|
|
| First sentence should end with a period. |
18
|
|
| Missing a Javadoc comment. |
23
|
|
| Missing a Javadoc comment. |
25
|
|
| Variable 'type' must be private and have accessor methods. |
25
|
|
| Missing a Javadoc comment. |
27
|
|
| Parameter type should be final. |
27
|
|
| 'type' hides a field. |
27
|
|
| Missing a Javadoc comment. |
31
|
|
| Parameter type should be final. |
31
|
|
| Missing a Javadoc comment. |
48
|
|
| Missing a Javadoc comment. |
52
|
|
| Parameter obj should be final. |
52
|
nl/toolforge/karma/core/location/PasswordScrambler.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
31
|
|
| '{' is not followed by whitespace. |
31
|
|
| '}' is not preceded with whitespace. |
31
|
|
| Line has trailing spaces. |
35
|
|
| Expected an @return tag. |
39
|
|
| Parameter password should be final. |
39
|
|
| Expected @param tag for 'password'. |
39
|
nl/toolforge/karma/core/location/RemoteLocation.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line has trailing spaces. |
9
|
nl/toolforge/karma/core/manifest/AbstractManifest.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
55
|
|
| Missing a Javadoc comment. |
57
|
|
| Missing a Javadoc comment. |
58
|
|
| Missing a Javadoc comment. |
59
|
|
| Missing a Javadoc comment. |
61
|
|
| Missing a Javadoc comment. |
63
|
|
| Missing a Javadoc comment. |
64
|
|
| Missing a Javadoc comment. |
66
|
|
| Missing a Javadoc comment. |
67
|
|
| Missing a Javadoc comment. |
68
|
|
| Parameter workingContext should be final. |
73
|
|
| 'workingContext' hides a field. |
73
|
|
| Expected @param tag for 'workingContext'. |
73
|
|
| Parameter name should be final. |
73
|
|
| 'name' hides a field. |
73
|
|
| Expected @param tag for 'name'. |
73
|
|
| Expected @throws tag for 'ManifestException'. |
73
|
|
| Expected @throws tag for 'LocationException'. |
73
|
|
| Parameter workingContext should be final. |
94
|
|
| 'workingContext' hides a field. |
94
|
|
| Parameter structure should be final. |
94
|
|
| Expected @throws tag for 'LocationException'. |
94
|
|
| Missing a Javadoc comment. |
104
|
|
| Missing a Javadoc comment. |
119
|
|
| Missing a Javadoc comment. |
154
|
|
| Parameter context should be final. |
175
|
|
| Parameter module should be final. |
175
|
|
| Missing a Javadoc comment. |
177
|
|
| Method 'getBuildBaseDirectory' is not designed for extension - needs to be abstract, final or empty. |
185
|
|
| Missing a Javadoc comment. |
185
|
|
| Method 'getReportsBaseDirectory' is not designed for extension - needs to be abstract, final or empty. |
195
|
|
| Missing a Javadoc comment. |
195
|
|
| Method 'getModuleBaseDirectory' is not designed for extension - needs to be abstract, final or empty. |
205
|
|
| Missing a Javadoc comment. |
205
|
|
| Missing a Javadoc comment. |
215
|
|
| Missing a Javadoc comment. |
232
|
|
| Parameter version should be final. |
249
|
|
| 'version' hides a field. |
249
|
|
| Missing a Javadoc comment. |
253
|
|
| Missing a Javadoc comment. |
257
|
|
| Parameter description should be final. |
257
|
|
| 'description' hides a field. |
257
|
|
| Expected an @return tag. |
307
|
|
| Parameter moduleName should be final. |
307
|
|
| Expected @param tag for 'moduleName'. |
307
|
|
| Expected @throws tag for 'ManifestException'. |
307
|
|
| Missing a Javadoc comment. |
318
|
|
| Missing a Javadoc comment. |
333
|
|
| Parameter module should be final. |
333
|
|
| Expected @throws tag for 'ManifestException'. |
350
|
|
| Expected an @return tag. |
359
|
|
| Parameter o should be final. |
359
|
|
| Conditional logic can be removed. |
362
|
|
| Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. |
372
|
|
| Missing a Javadoc comment. |
372
|
|
| Parameter module should be final. |
382
|
|
| Expected @param tag for 'module'. |
382
|
|
| Expected @throws tag for 'ManifestException'. |
382
|
|
| Avoid inline conditionals. |
386
|
|
| Expected an @return tag. |
398
|
|
| Expected @throws tag for 'ManifestException'. |
398
|
|
| Must have at least one statement. |
444
|
|
| Parameter module should be final. |
462
|
|
| Expected @param tag for 'module'. |
462
|
|
| Missing a Javadoc comment. |
478
|
|
| Parameter module should be final. |
478
|
|
| Line is longer than 120 characters. |
486
|
|
| 'catch' is not followed by whitespace. |
489
|
|
| Parameter module should be final. |
502
|
|
| Expected @param tag for 'module'. |
502
|
|
| Parameter state should be final. |
502
|
|
| Expected @param tag for 'state'. |
502
|
|
| Parameter dir should be final. |
516
|
|
| Parameter name should be final. |
516
|
|
| 'name' hides a field. |
516
|
|
| Conditional logic can be removed. |
517
|
|
| Missing a Javadoc comment. |
541
|
|
| Parameter module should be final. |
541
|
|
| Parameter dir should be final. |
552
|
|
| Parameter name should be final. |
552
|
|
| 'name' hides a field. |
552
|
|
| Conditional logic can be removed. |
553
|
|
| Missing a Javadoc comment. |
591
|
nl/toolforge/karma/core/manifest/DevelopmentManifest.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
31
|
|
| Missing a Javadoc comment. |
35
|
|
| Parameter workingContext should be final. |
35
|
|
| Parameter name should be final. |
35
|
|
| Missing a Javadoc comment. |
39
|
|
| Parameter context should be final. |
39
|
|
| Parameter structure should be final. |
39
|
|
| Parameter context should be final. |
51
|
|
| Expected @param tag for 'context'. |
51
|
|
| Parameter module should be final. |
51
|
|
| Expected @param tag for 'module'. |
51
|
nl/toolforge/karma/core/manifest/Manifest.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
33
|
|
| Redundant 'public' modifier. |
33
|
|
| Missing a Javadoc comment. |
34
|
|
| Redundant 'public' modifier. |
34
|
|
| Missing a Javadoc comment. |
36
|
|
| Redundant 'public' modifier. |
36
|
|
| Redundant 'public' modifier. |
43
|
|
| Redundant 'public' modifier. |
50
|
|
| Redundant 'public' modifier. |
57
|
|
| Redundant 'public' modifier. |
65
|
|
| Redundant 'public' modifier. |
73
|
|
| Redundant 'public' modifier. |
81
|
|
| Redundant 'public' modifier. |
89
|
|
| Redundant 'public' modifier. |
98
|
|
| Missing a Javadoc comment. |
100
|
|
| Redundant 'public' modifier. |
100
|
|
| Missing a Javadoc comment. |
102
|
|
| Redundant 'public' modifier. |
102
|
|
| Missing a Javadoc comment. |
104
|
|
| Redundant 'public' modifier. |
104
|
|
| Redundant 'public' modifier. |
119
|
|
| Redundant 'public' modifier. |
126
|
|
| Redundant 'public' modifier. |
133
|
|
| Redundant 'public' modifier. |
141
|
|
| Missing a Javadoc comment. |
143
|
|
| Redundant 'public' modifier. |
143
|
nl/toolforge/karma/core/manifest/ManifestCollector.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
42
|
|
| Missing a Javadoc comment. |
44
|
|
| Missing a Javadoc comment. |
45
|
|
| Missing a Javadoc comment. |
47
|
|
| Parameter workingContext should be final. |
47
|
|
| 'workingContext' hides a field. |
47
|
|
| Line has trailing spaces. |
53
|
|
| Expected an @return tag. |
56
|
|
| Method 'getAllManifests' is not designed for extension - needs to be abstract, final or empty. |
56
|
|
| Method 'refresh' is not designed for extension - needs to be abstract, final or empty. |
72
|
|
| Missing a Javadoc comment. |
72
|
|
| Method 'loadManifestFromHistory' is not designed for extension - needs to be abstract, final or empty. |
82
|
|
| Expected @throws tag for 'LocationException'. |
82
|
|
| Missing a Javadoc comment. |
99
|
nl/toolforge/karma/core/manifest/ManifestException.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
32
|
|
| Missing a Javadoc comment. |
33
|
|
| Missing a Javadoc comment. |
35
|
|
| First sentence should end with a period. |
72
|
|
| Missing a Javadoc comment. |
86
|
|
| Missing a Javadoc comment. |
88
|
|
| Parameter errorCode should be final. |
88
|
|
| 'errorCode' hides a field. |
88
|
|
| Missing a Javadoc comment. |
92
|
|
| Parameter errorCode should be final. |
92
|
|
| 'errorCode' hides a field. |
92
|
|
| Parameter messageArguments should be final. |
92
|
|
| 'messageArguments' hides a field. |
92
|
|
| Missing a Javadoc comment. |
98
|
|
| Parameter t should be final. |
98
|
|
| Parameter errorCode should be final. |
98
|
|
| 'errorCode' hides a field. |
98
|
|
| Parameter messageArguments should be final. |
98
|
|
| 'messageArguments' hides a field. |
98
|
|
| Method 'getMessage' is not designed for extension - needs to be abstract, final or empty. |
104
|
|
| Missing a Javadoc comment. |
104
|
|
| Expected an @return tag. |
115
|
|
| Missing a Javadoc comment. |
119
|
nl/toolforge/karma/core/manifest/ManifestFactory.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
35
|
|
| Parameter context should be final. |
35
|
|
| Parameter structure should be final. |
35
|
nl/toolforge/karma/core/manifest/ManifestHeader.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
29
|
|
| Missing a Javadoc comment. |
30
|
|
| Missing a Javadoc comment. |
32
|
|
| '{' is not followed by whitespace. |
32
|
|
| '}' is not preceded with whitespace. |
32
|
|
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
34
|
|
| Missing a Javadoc comment. |
34
|
|
| Method 'setName' is not designed for extension - needs to be abstract, final or empty. |
38
|
|
| Missing a Javadoc comment. |
38
|
|
| Parameter name should be final. |
38
|
|
| 'name' hides a field. |
38
|
|
| Method 'getType' is not designed for extension - needs to be abstract, final or empty. |
42
|
|
| Missing a Javadoc comment. |
42
|
|
| Method 'setType' is not designed for extension - needs to be abstract, final or empty. |
46
|
|
| Missing a Javadoc comment. |
46
|
|
| Parameter type should be final. |
46
|
|
| 'type' hides a field. |
46
|
nl/toolforge/karma/core/manifest/ManifestLoader.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
43
|
|
| Missing a Javadoc comment. |
45
|
|
| Missing a Javadoc comment. |
47
|
|
| Parameter workingContext should be final. |
47
|
|
| 'workingContext' hides a field. |
47
|
|
| Expected an @return tag. |
57
|
|
| Parameter manifest should be final. |
57
|
|
| Expected @throws tag for 'ManifestException'. |
57
|
|
| Missing a Javadoc comment. |
107
|
|
| Parameter id should be final. |
107
|
|
| Avoid inline conditionals. |
110
|
nl/toolforge/karma/core/manifest/ManifestStructure.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
38
|
|
| Missing a Javadoc comment. |
39
|
|
| Missing a Javadoc comment. |
40
|
|
| Missing a Javadoc comment. |
42
|
|
| Missing a Javadoc comment. |
44
|
|
| Missing a Javadoc comment. |
45
|
|
| Missing a Javadoc comment. |
47
|
|
| Missing a Javadoc comment. |
52
|
|
| Missing a Javadoc comment. |
56
|
|
| Parameter childName should be final. |
56
|
|
| Missing a Javadoc comment. |
60
|
|
| Parameter structure should be final. |
60
|
|
| Missing a Javadoc comment. |
67
|
|
| Missing a Javadoc comment. |
71
|
|
| Parameter digester should be final. |
71
|
|
| Missing a Javadoc comment. |
79
|
|
| Missing a Javadoc comment. |
83
|
|
| Parameter name should be final. |
83
|
|
| 'name' hides a field. |
83
|
|
| Missing a Javadoc comment. |
91
|
|
| Missing a Javadoc comment. |
95
|
|
| Parameter version should be final. |
95
|
|
| 'version' hides a field. |
95
|
|
| Missing a Javadoc comment. |
103
|
|
| Missing a Javadoc comment. |
107
|
|
| Parameter type should be final. |
107
|
|
| 'type' hides a field. |
107
|
|
| Missing a Javadoc comment. |
111
|
|
| Missing a Javadoc comment. |
115
|
|
| Parameter description should be final. |
115
|
|
| 'description' hides a field. |
115
|
|
| Missing a Javadoc comment. |
119
|
|
| Parameter child should be final. |
119
|
nl/toolforge/karma/core/manifest/ReleaseManifest.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
37
|
|
| Parameter context should be final. |
37
|
|
| Parameter structure should be final. |
37
|
|
| '100' is a magic number. |
51
|
|
| Missing a Javadoc comment. |
55
|
|
| Parameter context should be final. |
67
|
|
| Expected @param tag for 'context'. |
67
|
|
| Parameter module should be final. |
67
|
|
| Expected @param tag for 'module'. |
67
|
nl/toolforge/karma/core/manifest/digester/ModuleDescriptorCreationFactory.java
| Error | Line |
|---|
|
| Line is longer than 120 characters. |
26
|
|
| Unclosed HTML tag found: <code>location</locetion> are still |
28
|
|
| Extra HTML tag found: </locetion> are still |
28
|
|
| Method 'createObject' is not designed for extension - needs to be abstract, final or empty. |
36
|
|
| Missing a Javadoc comment. |
36
|
|
| Parameter attributes should be final. |
36
|
nl/toolforge/karma/core/manifest/digester/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
nl/toolforge/karma/core/module/BaseModule.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
62
|
|
| Variable 'logger' must be private and have accessor methods. |
62
|
|
| Missing a Javadoc comment. |
64
|
|
| Missing a Javadoc comment. |
65
|
|
| Missing a Javadoc comment. |
67
|
|
| Missing a Javadoc comment. |
69
|
|
| Missing a Javadoc comment. |
70
|
|
| Missing a Javadoc comment. |
71
|
|
| Missing a Javadoc comment. |
73
|
|
| Parameter name should be final. |
73
|
|
| 'name' hides a field. |
73
|
|
| Parameter location should be final. |
73
|
|
| 'location' hides a field. |
73
|
|
| Parameter version should be final. |
73
|
|
| 'version' hides a field. |
73
|
|
| Missing a Javadoc comment. |
78
|
|
| Parameter name should be final. |
78
|
|
| 'name' hides a field. |
78
|
|
| Parameter location should be final. |
78
|
|
| 'location' hides a field. |
78
|
|
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
110
|
|
| Missing a Javadoc comment. |
110
|
|
| Parameter obj should be final. |
110
|
|
| '&&' should be on a new line. |
113
|
|
| Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. |
121
|
|
| Missing a Javadoc comment. |
121
|
|
| Missing a Javadoc comment. |
135
|
|
| Parameter mark should be final. |
135
|
|
| Missing a Javadoc comment. |
139
|
|
| Missing a Javadoc comment. |
143
|
|
| Parameter mark should be final. |
143
|
|
| Missing a Javadoc comment. |
147
|
|
| Avoid inline conditionals. |
158
|
|
| Missing a Javadoc comment. |
161
|
|
| Line is longer than 120 characters. |
177
|
|
| Parameter baseDir should be final. |
182
|
|
| 'baseDir' hides a field. |
182
|
|
| Expected @param tag for 'baseDir'. |
182
|
|
| Missing a Javadoc comment. |
190
|
|
| Missing a Javadoc comment. |
198
|
|
| Line is longer than 120 characters. |
206
|
|
| Parameter authenticator should be final. |
206
|
|
| Expected @param tag for 'authenticator'. |
206
|
|
| Parameter createComment should be final. |
206
|
|
| Expected @param tag for 'createComment'. |
206
|
|
| Expected @throws tag for 'AuthenticationException'. |
206
|
|
| Expected @throws tag for 'VersionControlException'. |
206
|
|
| Line is longer than 120 characters. |
285
|
|
| Expected an @return tag. |
350
|
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
350
|
nl/toolforge/karma/core/module/JavaEnterpriseApplicationModule.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
35
|
|
| Parameter name should be final. |
35
|
|
| Parameter location should be final. |
35
|
|
| Method 'getLayoutTemplate' is not designed for extension - needs to be abstract, final or empty. |
44
|
|
| Missing a Javadoc comment. |
48
|
|
| Parameter name should be final. |
48
|
|
| Parameter location should be final. |
48
|
|
| Parameter version should be final. |
48
|
nl/toolforge/karma/core/module/JavaWebApplicationModule.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
35
|
|
| Parameter name should be final. |
35
|
|
| Parameter location should be final. |
35
|
|
| Method 'getLayoutTemplate' is not designed for extension - needs to be abstract, final or empty. |
44
|
|
| Missing a Javadoc comment. |
48
|
|
| Parameter name should be final. |
48
|
|
| Parameter location should be final. |
48
|
|
| Parameter version should be final. |
48
|
nl/toolforge/karma/core/module/LibModule.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
38
|
|
| Parameter name should be final. |
38
|
|
| Parameter location should be final. |
38
|
|
| Method 'getLayoutTemplate' is not designed for extension - needs to be abstract, final or empty. |
47
|
|
| Missing a Javadoc comment. |
51
|
|
| Parameter name should be final. |
51
|
|
| Parameter location should be final. |
51
|
|
| Parameter version should be final. |
51
|
|
| Method 'getLibraries' is not designed for extension - needs to be abstract, final or empty. |
55
|
|
| Missing a Javadoc comment. |
55
|
nl/toolforge/karma/core/module/MavenModule.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
34
|
|
| Parameter name should be final. |
34
|
|
| Parameter location should be final. |
34
|
|
| Missing a Javadoc comment. |
38
|
|
| Parameter name should be final. |
38
|
|
| Parameter location should be final. |
38
|
|
| Parameter version should be final. |
38
|
nl/toolforge/karma/core/module/Module.java
| Error | Line |
|---|
|
| Redundant 'public' modifier. |
52
|
|
| Redundant 'public' modifier. |
56
|
|
| Redundant 'public' modifier. |
60
|
|
| Redundant 'public' modifier. |
64
|
|
| Redundant 'public' modifier. |
68
|
|
| Redundant 'public' modifier. |
73
|
|
| Missing a Javadoc comment. |
75
|
|
| Redundant 'public' modifier. |
75
|
|
| Missing a Javadoc comment. |
76
|
|
| Redundant 'public' modifier. |
76
|
|
| Missing a Javadoc comment. |
77
|
|
| Redundant 'public' modifier. |
77
|
|
| Redundant 'public' modifier. |
82
|
|
| Redundant 'public' modifier. |
89
|
|
| Redundant 'public' modifier. |
96
|
|
| Expected @throws tag for 'ModuleTypeException'. |
96
|
|
| Expected an @return tag. |
101
|
|
| Redundant 'public' modifier. |
101
|
|
| Redundant 'public' modifier. |
109
|
|
| Redundant 'public' modifier. |
116
|
|
| Line has trailing spaces. |
121
|
|
| Redundant 'public' modifier. |
130
|
|
| Redundant 'public' modifier. |
137
|
|
| Expected @param tag for 'mark'. |
137
|
|
| Missing a Javadoc comment. |
139
|
|
| Redundant 'public' modifier. |
139
|
|
| Expected an @return tag. |
148
|
|
| Redundant 'public' modifier. |
148
|
|
| Redundant 'public' modifier. |
153
|
|
| Expected @param tag for 'mark'. |
153
|
|
| Redundant 'public' modifier. |
161
|
|
| Redundant 'public' modifier. |
169
|
|
| Unclosed HTML tag found: <ode>true</code> if the module has a <version>-attribu |
174
|
|
| Extra HTML tag found: </code> if the module has a <version>-attribute or <co |
174
|
|
| Redundant 'public' modifier. |
176
|
|
| Line has trailing spaces. |
180
|
|
| Redundant 'public' modifier. |
184
|
|
| Redundant 'public' modifier. |
191
|
|
| Line is longer than 120 characters. |
193
|
|
| Missing a Javadoc comment. |
193
|
|
| Redundant 'public' modifier. |
193
|
|
| ';' is preceded with whitespace. |
193
|
|
| Missing a Javadoc comment. |
203
|
|
| Missing a Javadoc comment. |
204
|
|
| Missing a Javadoc comment. |
206
|
|
| '{' is not followed by whitespace. |
206
|
|
| '}' is not preceded with whitespace. |
206
|
|
| Missing a Javadoc comment. |
208
|
|
| Parameter type should be final. |
208
|
|
| 'type' hides a field. |
208
|
|
| Missing a Javadoc comment. |
213
|
|
| Parameter type should be final. |
213
|
|
| 'type' hides a field. |
213
|
|
| Missing a Javadoc comment. |
234
|
|
| Missing a Javadoc comment. |
238
|
|
| Missing a Javadoc comment. |
242
|
|
| Line has trailing spaces. |
245
|
|
| Missing a Javadoc comment. |
246
|
|
| Missing a Javadoc comment. |
250
|
|
| Parameter o should be final. |
250
|
|
| Conditional logic can be removed. |
252
|
|
| Missing a Javadoc comment. |
284
|
|
| Parameter stateString should be final. |
291
|
|
| Expected @param tag for 'stateString'. |
291
|
|
| Missing a Javadoc comment. |
309
|
|
| Parameter o should be final. |
321
|
|
| Conditional logic can be removed. |
324
|
|
| Expected an @return tag. |
339
|
nl/toolforge/karma/core/module/ModuleComparator.java
| Error | Line |
|---|
|
| Method 'compare' is not designed for extension - needs to be abstract, final or empty. |
31
|
|
| Missing a Javadoc comment. |
31
|
|
| Parameter o1 should be final. |
31
|
|
| Parameter o2 should be final. |
31
|
|
| Line is longer than 120 characters. |
34
|
nl/toolforge/karma/core/module/ModuleDescriptor.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
36
|
|
| Variable 'logger' must be private and have accessor methods. |
36
|
|
| Missing a Javadoc comment. |
38
|
|
| Missing a Javadoc comment. |
40
|
|
| Parameter module should be final. |
40
|
|
| Method 'createFile' is not designed for extension - needs to be abstract, final or empty. |
66
|
|
| Parameter dir should be final. |
66
|
|
| Expected @throws tag for 'IOException'. |
66
|
nl/toolforge/karma/core/module/ModuleDigester.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
36
|
|
| Missing a Javadoc comment. |
37
|
|
| Missing a Javadoc comment. |
39
|
|
| Missing a Javadoc comment. |
40
|
|
| Missing a Javadoc comment. |
42
|
|
| Parameter name should be final. |
47
|
|
| 'name' hides a field. |
47
|
|
| Expected @param tag for 'name'. |
47
|
|
| Parameter location should be final. |
47
|
|
| 'location' hides a field. |
47
|
|
| Expected @param tag for 'location'. |
47
|
|
| Missing a Javadoc comment. |
63
|
|
| Missing a Javadoc comment. |
67
|
|
| Parameter version should be final. |
77
|
|
| 'version' hides a field. |
77
|
|
| Missing a Javadoc comment. |
86
|
|
| Parameter o should be final. |
96
|
|
| Conditional logic can be removed. |
99
|
|
| '&&' should be on a new line. |
100
|
|
| ')' is preceded with whitespace. |
101
|
|
| Missing a Javadoc comment. |
111
|
nl/toolforge/karma/core/module/ModuleFactory.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
nl/toolforge/karma/core/module/ModuleFactory.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
35
|
|
| Missing a Javadoc comment. |
37
|
|
| Parameter workingContext should be final. |
37
|
|
| 'workingContext' hides a field. |
37
|
|
| Missing a Javadoc comment. |
41
|
|
| Parameter digester should be final. |
41
|
|
| Parameter moduleType should be final. |
41
|
nl/toolforge/karma/core/module/ModuleTypeException.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
32
|
|
| Missing a Javadoc comment. |
33
|
|
| Missing a Javadoc comment. |
35
|
|
| Missing a Javadoc comment. |
37
|
|
| Missing a Javadoc comment. |
38
|
|
| Missing a Javadoc comment. |
40
|
|
| Parameter errorCode should be final. |
40
|
|
| 'errorCode' hides a field. |
40
|
|
| Missing a Javadoc comment. |
44
|
|
| Parameter errorCode should be final. |
44
|
|
| 'errorCode' hides a field. |
44
|
|
| Parameter messageArguments should be final. |
44
|
|
| 'messageArguments' hides a field. |
44
|
|
| Missing a Javadoc comment. |
50
|
|
| Parameter t should be final. |
50
|
|
| Parameter errorCode should be final. |
50
|
|
| 'errorCode' hides a field. |
50
|
|
| Parameter messageArguments should be final. |
50
|
|
| 'messageArguments' hides a field. |
50
|
|
| Expected an @return tag. |
61
|
|
| Method 'getMessage' is not designed for extension - needs to be abstract, final or empty. |
68
|
|
| Missing a Javadoc comment. |
68
|
|
| Expected an @return tag. |
76
|
|
| Missing a Javadoc comment. |
80
|
nl/toolforge/karma/core/module/OtherModule.java
| Error | Line |
|---|
|
| Parameter name should be final. |
42
|
|
| Parameter location should be final. |
42
|
|
| Parameter name should be final. |
49
|
|
| Expected @param tag for 'name'. |
49
|
|
| Parameter location should be final. |
49
|
|
| Expected @param tag for 'location'. |
49
|
|
| Parameter version should be final. |
49
|
|
| Expected @param tag for 'version'. |
49
|
|
| Method 'getInstanceType' is not designed for extension - needs to be abstract, final or empty. |
53
|
|
| Missing a Javadoc comment. |
53
|
|
| Method 'getLayoutTemplate' is not designed for extension - needs to be abstract, final or empty. |
57
|
|
| Missing a Javadoc comment. |
57
|
nl/toolforge/karma/core/module/SourceModule.java
| Error | Line |
|---|
|
| Parameter name should be final. |
42
|
|
| Parameter location should be final. |
42
|
|
| Method 'getInstanceType' is not designed for extension - needs to be abstract, final or empty. |
46
|
|
| Missing a Javadoc comment. |
46
|
|
| Method 'getLayoutTemplate' is not designed for extension - needs to be abstract, final or empty. |
50
|
|
| Missing a Javadoc comment. |
50
|
|
| Parameter name should be final. |
57
|
|
| Expected @param tag for 'name'. |
57
|
|
| Parameter location should be final. |
57
|
|
| Expected @param tag for 'location'. |
57
|
|
| Parameter version should be final. |
57
|
|
| Expected @param tag for 'version'. |
57
|
nl/toolforge/karma/core/module/UntypedModule.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
37
|
|
| Parameter name should be final. |
37
|
|
| Parameter location should be final. |
37
|
|
| Line is longer than 120 characters. |
42
|
|
| Expected an @return tag. |
54
|
|
| Missing a Javadoc comment. |
58
|
|
| Parameter name should be final. |
58
|
|
| Parameter location should be final. |
58
|
|
| Parameter version should be final. |
58
|
nl/toolforge/karma/core/module/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
nl/toolforge/karma/core/module/template/BaseModuleLayoutTemplate.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
39
|
|
| Variable 'logger' must be private and have accessor methods. |
39
|
|
| Missing a Javadoc comment. |
41
|
|
| Missing a Javadoc comment. |
43
|
|
| Missing a Javadoc comment. |
45
|
|
| Parameter baseDir should be final. |
45
|
|
| Line is longer than 120 characters. |
54
|
|
| ',' is not followed by whitespace. |
54
|
|
| '=' is not preceded with whitespace. |
73
|
|
| '=' is not followed by whitespace. |
73
|
nl/toolforge/karma/core/module/template/EappModuleLayoutTemplate.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
37
|
|
| Missing a Javadoc comment. |
45
|
nl/toolforge/karma/core/module/template/FileTemplate.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
31
|
|
| Missing a Javadoc comment. |
32
|
|
| Parameter source should be final. |
46
|
|
| 'source' hides a field. |
46
|
|
| Parameter target should be final. |
46
|
|
| 'target' hides a field. |
46
|
|
| Method 'getSource' is not designed for extension - needs to be abstract, final or empty. |
61
|
|
| Method 'getTarget' is not designed for extension - needs to be abstract, final or empty. |
69
|
nl/toolforge/karma/core/module/template/LibModuleLayoutTemplate.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
39
|
|
| Missing a Javadoc comment. |
45
|
nl/toolforge/karma/core/module/template/ModuleLayoutTemplate.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
34
|
|
| Redundant 'public' modifier. |
34
|
|
| Missing a Javadoc comment. |
36
|
|
| Redundant 'public' modifier. |
36
|
|
| Line has trailing spaces. |
40
|
|
| Redundant 'public' modifier. |
44
|
|
| Expected @param tag for 'baseDir'. |
44
|
|
| Expected @throws tag for 'IOException'. |
44
|
nl/toolforge/karma/core/module/template/OtherModuleLayoutTemplate.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
39
|
|
| Missing a Javadoc comment. |
45
|
|
| '{' is followed by whitespace. |
46
|
nl/toolforge/karma/core/module/template/SourceModuleLayoutTemplate.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
42
|
|
| Missing a Javadoc comment. |
49
|
nl/toolforge/karma/core/module/template/WebappModuleLayoutTemplate.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
42
|
|
| ',' is not followed by whitespace. |
46
|
|
| Missing a Javadoc comment. |
50
|
nl/toolforge/karma/core/module/template/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
nl/toolforge/karma/core/scm/ModuleDependency.java
| Error | Line |
|---|
|
| Line is longer than 120 characters. |
39
|
|
| Line is longer than 120 characters. |
40
|
|
| Missing a Javadoc comment. |
50
|
|
| Missing a Javadoc comment. |
51
|
|
| Missing a Javadoc comment. |
53
|
|
| Missing a Javadoc comment. |
54
|
|
| Missing a Javadoc comment. |
55
|
|
| Missing a Javadoc comment. |
56
|
|
| Missing a Javadoc comment. |
58
|
|
| Missing a Javadoc comment. |
60
|
|
| Missing a Javadoc comment. |
63
|
|
| Missing a Javadoc comment. |
67
|
|
| Parameter id should be final. |
67
|
|
| 'id' hides a field. |
67
|
|
| Missing a Javadoc comment. |
71
|
|
| Missing a Javadoc comment. |
75
|
|
| Parameter groupId should be final. |
75
|
|
| 'groupId' hides a field. |
75
|
|
| Missing a Javadoc comment. |
79
|
|
| Missing a Javadoc comment. |
83
|
|
| Parameter artifactId should be final. |
83
|
|
| 'artifactId' hides a field. |
83
|
|
| Missing a Javadoc comment. |
87
|
|
| Missing a Javadoc comment. |
91
|
|
| Parameter version should be final. |
91
|
|
| 'version' hides a field. |
91
|
|
| Missing a Javadoc comment. |
95
|
|
| Missing a Javadoc comment. |
99
|
|
| Parameter module should be final. |
99
|
|
| 'module' hides a field. |
99
|
|
| Missing a Javadoc comment. |
103
|
|
| Missing a Javadoc comment. |
107
|
|
| Parameter libModule should be final. |
107
|
|
| 'libModule' hides a field. |
107
|
|
| Missing a Javadoc comment. |
111
|
|
| Missing a Javadoc comment. |
115
|
|
| Parameter jar should be final. |
115
|
|
| 'jar' hides a field. |
115
|
|
| Missing a Javadoc comment. |
119
|
|
| Parameter b should be final. |
119
|
|
| Missing a Javadoc comment. |
123
|
|
| Missing a Javadoc comment. |
127
|
|
| Expected an @return tag. |
154
|
|
| Expected an @return tag. |
165
|
|
| Expected an @return tag. |
178
|
|
| Expected an @return tag. |
197
|
|
| Parameter obj should be final. |
197
|
|
| '{' is not preceded with whitespace. |
205
|
|
| '&&' should be on a new line. |
208
|
|
| Missing a Javadoc comment. |
216
|
|
| '+' is not preceded with whitespace. |
220
|
|
| '+' is not followed by whitespace. |
220
|
|
| '+' is not preceded with whitespace. |
220
|
|
| '+' is not followed by whitespace. |
220
|
|
| '+' is not preceded with whitespace. |
222
|
|
| '+' is not followed by whitespace. |
222
|
|
| '+' is not preceded with whitespace. |
222
|
|
| '+' is not followed by whitespace. |
222
|
|
| '+' is not preceded with whitespace. |
222
|
|
| '+' is not followed by whitespace. |
222
|
|
| '+' is not preceded with whitespace. |
222
|
|
| '+' is not followed by whitespace. |
222
|
|
| '+' is not preceded with whitespace. |
222
|
|
| '+' is not followed by whitespace. |
222
|
|
| '+' is not preceded with whitespace. |
222
|
|
| '+' is not followed by whitespace. |
222
|
|
| '+' is not preceded with whitespace. |
224
|
|
| '+' is not followed by whitespace. |
224
|
|
| '+' is not preceded with whitespace. |
224
|
|
| '+' is not followed by whitespace. |
224
|
|
| '+' is not preceded with whitespace. |
224
|
|
| '+' is not followed by whitespace. |
224
|
|
| '+' is not preceded with whitespace. |
224
|
|
| '+' is not followed by whitespace. |
224
|
|
| '+' is not preceded with whitespace. |
226
|
|
| '+' is not followed by whitespace. |
226
|
|
| '+' is not preceded with whitespace. |
226
|
|
| '+' is not followed by whitespace. |
226
|
|
| '+' is not preceded with whitespace. |
226
|
|
| '+' is not followed by whitespace. |
226
|
|
| '+' is not preceded with whitespace. |
226
|
|
| '+' is not followed by whitespace. |
226
|
|
| '+' is not preceded with whitespace. |
226
|
|
| '+' is not followed by whitespace. |
226
|
|
| '+' is not preceded with whitespace. |
226
|
|
| '+' is not followed by whitespace. |
226
|
nl/toolforge/karma/core/scm/digester/ModuleDependencyCreationFactory.java
| Error | Line |
|---|
|
| Method 'createObject' is not designed for extension - needs to be abstract, final or empty. |
33
|
|
| Missing a Javadoc comment. |
33
|
|
| Parameter attributes should be final. |
33
|
nl/toolforge/karma/core/scm/digester/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
nl/toolforge/karma/core/scm/maven/MavenDependencyReader.java
| Error | Line |
|---|
|
| Method 'parse' is not designed for extension - needs to be abstract, final or empty. |
49
|
|
| Parameter dependencyFileIs should be final. |
49
|
|
| Expected @param tag for 'dependencyFileIs'. |
49
|
|
| Expected @throws tag for 'KarmaException'. |
49
|
|
| Method 'parse' is not designed for extension - needs to be abstract, final or empty. |
85
|
|
| Missing a Javadoc comment. |
85
|
|
| Parameter projectXmlFile should be final. |
85
|
nl/toolforge/karma/core/scm/maven/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
nl/toolforge/karma/core/test/BaseTest.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
40
|
|
| Missing a Javadoc comment. |
41
|
|
| Missing a Javadoc comment. |
42
|
|
| Missing a Javadoc comment. |
43
|
|
| Method 'setUp' is not designed for extension - needs to be abstract, final or empty. |
45
|
|
| Missing a Javadoc comment. |
45
|
|
| Line is longer than 120 characters. |
77
|
|
| Line is longer than 120 characters. |
82
|
|
| Line is longer than 120 characters. |
83
|
|
| Line is longer than 120 characters. |
85
|
|
| Line is longer than 120 characters. |
86
|
|
| Line is longer than 120 characters. |
87
|
|
| Line is longer than 120 characters. |
89
|
|
| Line is longer than 120 characters. |
90
|
|
| Method 'getWorkingContext' is not designed for extension - needs to be abstract, final or empty. |
99
|
|
| Missing a Javadoc comment. |
99
|
|
| Method 'tearDown' is not designed for extension - needs to be abstract, final or empty. |
103
|
|
| Missing a Javadoc comment. |
103
|
|
| '}' should be on the same line. |
114
|
|
| Expected an @return tag. |
123
|
|
| Method 'getClassLoader' is not designed for extension - needs to be abstract, final or empty. |
123
|
nl/toolforge/karma/core/test/CommandResponseFaker.java
| Error | Line |
|---|
|
| Parameter command should be final. |
37
|
|
| Expected @param tag for 'command'. |
37
|
|
| Parameter message should be final. |
45
|
|
| Expected @param tag for 'message'. |
45
|
|
| '{' is not followed by whitespace. |
45
|
|
| '}' is not preceded with whitespace. |
45
|
|
| Line has trailing spaces. |
46
|
nl/toolforge/karma/core/test/CommandTestHelper.java
| Error | Line |
|---|
|
| Method 'testBogus' is not designed for extension - needs to be abstract, final or empty. |
32
|
|
| Expected an @return tag. |
39
|
nl/toolforge/karma/core/test/InitializationException.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
nl/toolforge/karma/core/test/InitializationException.java
| Error | Line |
|---|
|
| Line contains a tab character. |
29
|
|
| Missing a Javadoc comment. |
29
|
|
| Parameter message should be final. |
29
|
|
| Line contains a tab character. |
30
|
|
| Line contains a tab character. |
31
|
nl/toolforge/karma/core/test/LocalCVSInitializer.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
nl/toolforge/karma/core/test/LocalCVSInitializer.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
62
|
|
| First sentence should end with a period. |
64
|
|
| Missing a Javadoc comment. |
69
|
|
| Missing a Javadoc comment. |
70
|
|
| Variable 'randomizer' must be private and have accessor methods. |
75
|
|
| Method 'setUp' is not designed for extension - needs to be abstract, final or empty. |
77
|
|
| Missing a Javadoc comment. |
77
|
|
| Redundant throws: 'InitializationException' is unchecked exception. |
77
|
|
| Line is longer than 120 characters. |
120
|
|
| Method 'tearDown' is not designed for extension - needs to be abstract, final or empty. |
128
|
|
| Expected an @return tag. |
142
|
|
| Method 'getTestLocation' is not designed for extension - needs to be abstract, final or empty. |
142
|
|
| Expected an @return tag. |
150
|
|
| Method 'getTestFileName' is not designed for extension - needs to be abstract, final or empty. |
150
|
|
| Expected @throws tag for 'InitializationException'. |
150
|
|
| Redundant throws: 'InitializationException' is unchecked exception. |
150
|
|
| Avoid inline conditionals. |
153
|
|
| Expected an @return tag. |
161
|
|
| Missing a Javadoc comment. |
180
|
|
| Expected @throws tag for 'AuthenticationException'. |
205
|
|
| Expected an @return tag. |
216
|
|
| Parameter response should be final. |
216
|
|
| Expected @param tag for 'response'. |
216
|
|
| Expected @throws tag for 'AuthenticationException'. |
216
|
|
| Method 'testNothing' is not designed for extension - needs to be abstract, final or empty. |
230
|
nl/toolforge/karma/core/vc/AuthenticationException.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
29
|
|
| Missing a Javadoc comment. |
30
|
|
| First sentence should end with a period. |
58
|
|
| Missing a Javadoc comment. |
63
|
|
| Parameter errorCode should be final. |
63
|
|
| 'errorCode' hides a field. |
63
|
|
| Missing a Javadoc comment. |
67
|
|
| Parameter t should be final. |
67
|
|
| Parameter errorCode should be final. |
67
|
|
| 'errorCode' hides a field. |
67
|
|
| Missing a Javadoc comment. |
71
|
|
| Parameter errorCode should be final. |
71
|
|
| 'errorCode' hides a field. |
71
|
|
| Parameter messageArguments should be final. |
71
|
|
| 'messageArguments' hides a field. |
71
|
|
| Missing a Javadoc comment. |
77
|
|
| Parameter t should be final. |
77
|
|
| Parameter errorCode should be final. |
77
|
|
| 'errorCode' hides a field. |
77
|
|
| Parameter messageArguments should be final. |
77
|
|
| 'messageArguments' hides a field. |
77
|
|
| Method 'getMessage' is not designed for extension - needs to be abstract, final or empty. |
83
|
|
| Missing a Javadoc comment. |
83
|
|
| Expected an @return tag. |
93
|
|
| Expected an @return tag. |
100
|
nl/toolforge/karma/core/vc/Authenticator.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
29
|
|
| Missing a Javadoc comment. |
30
|
|
| Missing a Javadoc comment. |
31
|
|
| Missing a Javadoc comment. |
32
|
|
| Missing a Javadoc comment. |
34
|
|
| Parameter id should be final. |
34
|
|
| 'id' hides a field. |
34
|
|
| Missing a Javadoc comment. |
45
|
|
| Missing a Javadoc comment. |
49
|
|
| Parameter workingContext should be final. |
49
|
|
| 'workingContext' hides a field. |
49
|
|
| Missing a Javadoc comment. |
58
|
|
| Missing a Javadoc comment. |
63
|
|
| Parameter id should be final. |
63
|
|
| 'id' hides a field. |
63
|
|
| Missing a Javadoc comment. |
72
|
|
| Missing a Javadoc comment. |
76
|
|
| Parameter username should be final. |
76
|
|
| 'username' hides a field. |
76
|
|
| Expected an @return tag. |
85
|
|
| Avoid inline conditionals. |
86
|
|
| Missing a Javadoc comment. |
89
|
|
| Parameter password should be final. |
89
|
|
| 'password' hides a field. |
89
|
|
| Missing a Javadoc comment. |
93
|
nl/toolforge/karma/core/vc/AuthenticatorKey.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
27
|
|
| Missing a Javadoc comment. |
28
|
|
| Line has trailing spaces. |
34
|
|
| Unused @throws tag for 'IllegalArgumentException'. |
34
|
|
| Parameter workingContext should be final. |
36
|
|
| 'workingContext' hides a field. |
36
|
|
| Parameter locationId should be final. |
36
|
|
| 'locationId' hides a field. |
36
|
|
| Missing a Javadoc comment. |
46
|
|
| Missing a Javadoc comment. |
50
|
|
| Parameter obj should be final. |
50
|
|
| '&&' should be on a new line. |
54
|
|
| Missing a Javadoc comment. |
61
|
nl/toolforge/karma/core/vc/Authenticators.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
56
|
|
| '{' is not followed by whitespace. |
61
|
|
| '}' is not preceded with whitespace. |
61
|
|
| Line is longer than 120 characters. |
63
|
|
| Missing a Javadoc comment. |
63
|
|
| Parameter key should be final. |
63
|
|
| Parameter newPassword should be final. |
63
|
|
| Missing a Javadoc comment. |
86
|
|
| Parameter authenticator should be final. |
86
|
|
| Parameter key should be final. |
97
|
|
| Missing a Javadoc comment. |
112
|
|
| Missing a Javadoc comment. |
113
|
|
| Should use uppercase 'L'. |
113
|
|
| Missing a Javadoc comment. |
115
|
|
| 'static' modifier out of order with the JLS suggestions. |
115
|
|
| Parameter authenticator should be final. |
176
|
|
| Expected @param tag for 'authenticator'. |
176
|
|
| Expected @throws tag for 'AuthenticationException'. |
176
|
|
| Parameter authenticator should be final. |
198
|
|
| Expected @param tag for 'authenticator'. |
198
|
|
| Expected @throws tag for 'AuthenticationException'. |
198
|
|
| Line is longer than 120 characters. |
202
|
|
| Missing a Javadoc comment. |
211
|
|
| Missing a Javadoc comment. |
219
|
|
| Parameter authenticators should be final. |
219
|
|
| Line is longer than 120 characters. |
231
|
|
| Missing a Javadoc comment. |
265
|
|
| Line is longer than 120 characters. |
272
|
nl/toolforge/karma/core/vc/DevelopmentLine.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
34
|
|
| Missing a Javadoc comment. |
36
|
|
| Parameter lineName should be final. |
43
|
|
| 'lineName' hides a field. |
43
|
|
| Line is longer than 120 characters. |
46
|
|
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
51
|
|
| Missing a Javadoc comment. |
51
|
|
| Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. |
59
|
|
| Missing a Javadoc comment. |
59
|
|
| Method 'getPatternString' is not designed for extension - needs to be abstract, final or empty. |
63
|
|
| Missing a Javadoc comment. |
63
|
|
| Expected an @return tag. |
72
|
|
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
72
|
|
| Parameter o should be final. |
72
|
nl/toolforge/karma/core/vc/ModuleStatus.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
49
|
|
| Redundant 'public' modifier. |
49
|
|
| Missing a Javadoc comment. |
51
|
|
| Redundant 'public' modifier. |
51
|
|
| Missing a Javadoc comment. |
53
|
|
| Redundant 'public' modifier. |
53
|
|
| Missing a Javadoc comment. |
55
|
|
| Redundant 'public' modifier. |
55
|
|
| Missing a Javadoc comment. |
57
|
|
| Redundant 'public' modifier. |
57
|
|
| Missing a Javadoc comment. |
59
|
|
| Redundant 'public' modifier. |
59
|
|
| Missing a Javadoc comment. |
61
|
|
| Redundant 'public' modifier. |
61
|
|
| Missing a Javadoc comment. |
63
|
|
| Redundant 'public' modifier. |
63
|
|
| Missing a Javadoc comment. |
65
|
|
| Redundant 'public' modifier. |
65
|
|
| Missing a Javadoc comment. |
67
|
|
| Redundant 'public' modifier. |
67
|
nl/toolforge/karma/core/vc/PatchLine.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
40
|
|
| Missing a Javadoc comment. |
41
|
|
| Missing a Javadoc comment. |
43
|
|
| Missing a Javadoc comment. |
44
|
|
| Missing a Javadoc comment. |
46
|
|
| Parameter version should be final. |
53
|
|
| 'version' hides a field. |
53
|
|
| Method 'getPatternString' is not designed for extension - needs to be abstract, final or empty. |
59
|
|
| Missing a Javadoc comment. |
59
|
|
| Method 'getMatchingPattern' is not designed for extension - needs to be abstract, final or empty. |
71
|
nl/toolforge/karma/core/vc/Runner.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
36
|
|
| Redundant 'public' modifier. |
36
|
|
| Redundant 'public' modifier. |
44
|
|
| Expected @param tag for 'file'. |
44
|
|
| Line contains a tab character. |
46
|
|
| Line is longer than 120 characters. |
47
|
|
| Line contains a tab character. |
47
|
|
| Line contains a tab character. |
49
|
|
| Line contains a tab character. |
50
|
|
| Line contains a tab character. |
51
|
|
| Line contains a tab character. |
52
|
|
| Line contains a tab character. |
55
|
|
| Redundant 'public' modifier. |
56
|
|
| Redundant 'public' modifier. |
68
|
|
| Line contains a tab character. |
71
|
|
| Line contains a tab character. |
72
|
|
| Line contains a tab character. |
73
|
|
| Line contains a tab character. |
76
|
|
| Line contains a tab character. |
77
|
|
| Redundant 'public' modifier. |
77
|
|
| Line contains a tab character. |
79
|
|
| Line is longer than 120 characters. |
80
|
|
| Line contains a tab character. |
80
|
|
| Line contains a tab character. |
82
|
|
| Line contains a tab character. |
83
|
|
| Line contains a tab character. |
84
|
|
| Line contains a tab character. |
87
|
|
| Line contains a tab character. |
88
|
|
| Redundant 'public' modifier. |
88
|
|
| Line contains a tab character. |
90
|
|
| Line is longer than 120 characters. |
91
|
|
| Line contains a tab character. |
91
|
|
| Line contains a tab character. |
94
|
|
| Line contains a tab character. |
95
|
|
| Line contains a tab character. |
97
|
|
| Line contains a tab character. |
100
|
|
| Redundant 'public' modifier. |
101
|
|
| Line contains a tab character. |
103
|
|
| Line contains a tab character. |
104
|
|
| Line contains a tab character. |
105
|
|
| Line contains a tab character. |
106
|
|
| Line contains a tab character. |
109
|
|
| Line contains a tab character. |
110
|
|
| Redundant 'public' modifier. |
110
|
|
| Line contains a tab character. |
112
|
|
| Line contains a tab character. |
113
|
|
| Line contains a tab character. |
114
|
|
| Line contains a tab character. |
115
|
|
| Line contains a tab character. |
116
|
|
| Line contains a tab character. |
119
|
|
| Line contains a tab character. |
120
|
|
| Redundant 'public' modifier. |
120
|
|
| Line contains a tab character. |
129
|
|
| Redundant 'public' modifier. |
129
|
|
| Expected @param tag for 'module'. |
129
|
|
| Expected @param tag for 'version'. |
129
|
|
| Expected @throws tag for 'VersionControlException'. |
129
|
|
| Line is longer than 120 characters. |
136
|
|
| Redundant 'public' modifier. |
137
|
|
| Expected @param tag for 'module'. |
137
|
|
| Expected an @return tag. |
144
|
|
| Redundant 'public' modifier. |
144
|
|
| Expected @param tag for 'module'. |
144
|
|
| Unclosed HTML tag found: <code>PatchLine<code> for the module. |
147
|
|
| Redundant 'public' modifier. |
149
|
|
| Expected @param tag for 'module'. |
149
|
|
| Expected @throws tag for 'VersionControlException'. |
149
|
|
| ';' is preceded with whitespace. |
149
|
|
| Missing a Javadoc comment. |
151
|
|
| Redundant 'public' modifier. |
151
|
|
| Missing a Javadoc comment. |
153
|
nl/toolforge/karma/core/vc/RunnerFactory.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
37
|
|
| Missing a Javadoc comment. |
39
|
|
| '{' is not followed by whitespace. |
39
|
|
| '}' is not preceded with whitespace. |
39
|
|
| Parameter location should be final. |
51
|
|
| Expected @throws tag for 'VersionControlException'. |
51
|
|
| Expected @throws tag for 'AuthenticationException'. |
51
|
nl/toolforge/karma/core/vc/SymbolicName.java
| Error | Line |
|---|
|
| Line contains a tab character. |
27
|
|
| Line contains a tab character. |
28
|
|
| Line contains a tab character. |
29
|
|
| Expected an @return tag. |
30
|
|
| Line contains a tab character. |
30
|
|
| Redundant 'public' modifier. |
30
|
|
| Line contains a tab character. |
32
|
|
| Missing a Javadoc comment. |
32
|
|
| Redundant 'public' modifier. |
32
|
|
| Line contains a tab character. |
34
|
|
| Line contains a tab character. |
35
|
|
| Line contains a tab character. |
36
|
|
| Expected an @return tag. |
37
|
|
| Line contains a tab character. |
37
|
|
| Redundant 'public' modifier. |
37
|
nl/toolforge/karma/core/vc/VersionControlException.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
nl/toolforge/karma/core/vc/VersionControlException.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
31
|
|
| Missing a Javadoc comment. |
32
|
|
| Missing a Javadoc comment. |
34
|
|
| Name 'EXCEPTION_PREFIX' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
34
|
|
| Variable 'EXCEPTION_PREFIX' must be private and have accessor methods. |
34
|
|
| First sentence should end with a period. |
37
|
|
| Missing a Javadoc comment. |
43
|
|
| Parameter errorCode should be final. |
43
|
|
| 'errorCode' hides a field. |
43
|
|
| Missing a Javadoc comment. |
47
|
|
| Parameter t should be final. |
47
|
|
| Parameter errorCode should be final. |
47
|
|
| 'errorCode' hides a field. |
47
|
|
| Missing a Javadoc comment. |
51
|
|
| Parameter errorCode should be final. |
51
|
|
| 'errorCode' hides a field. |
51
|
|
| Parameter messageArguments should be final. |
51
|
|
| 'messageArguments' hides a field. |
51
|
|
| Line has trailing spaces. |
56
|
|
| Missing a Javadoc comment. |
57
|
|
| Parameter t should be final. |
57
|
|
| Parameter errorCode should be final. |
57
|
|
| 'errorCode' hides a field. |
57
|
|
| Parameter messageArguments should be final. |
57
|
|
| 'messageArguments' hides a field. |
57
|
|
| Method 'getMessage' is not designed for extension - needs to be abstract, final or empty. |
63
|
|
| Missing a Javadoc comment. |
63
|
|
| Expected an @return tag. |
74
|
|
| Missing a Javadoc comment. |
78
|
nl/toolforge/karma/core/vc/VersionControlSystem.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
36
|
|
| Missing a Javadoc comment. |
37
|
|
| Missing a Javadoc comment. |
38
|
|
| Missing a Javadoc comment. |
39
|
|
| Missing a Javadoc comment. |
40
|
|
| Missing a Javadoc comment. |
42
|
|
| Missing a Javadoc comment. |
44
|
|
| Parameter id should be final. |
44
|
|
| Parameter type should be final. |
44
|
|
| Method 'setHost' is not designed for extension - needs to be abstract, final or empty. |
48
|
|
| Missing a Javadoc comment. |
48
|
|
| Parameter host should be final. |
48
|
|
| 'host' hides a field. |
48
|
|
| Method 'getHost' is not designed for extension - needs to be abstract, final or empty. |
53
|
|
| Missing a Javadoc comment. |
53
|
|
| Method 'setProtocol' is not designed for extension - needs to be abstract, final or empty. |
62
|
|
| Parameter protocol should be final. |
62
|
|
| 'protocol' hides a field. |
62
|
|
| Method 'getProtocol' is not designed for extension - needs to be abstract, final or empty. |
67
|
|
| Missing a Javadoc comment. |
67
|
|
| Method 'setPort' is not designed for extension - needs to be abstract, final or empty. |
72
|
|
| Missing a Javadoc comment. |
72
|
|
| Parameter port should be final. |
72
|
|
| 'port' hides a field. |
72
|
|
| Method 'setPort' is not designed for extension - needs to be abstract, final or empty. |
81
|
|
| Parameter port should be final. |
81
|
|
| 'port' hides a field. |
81
|
|
| Expected @param tag for 'port'. |
81
|
|
| Method 'getPort' is not designed for extension - needs to be abstract, final or empty. |
90
|
|
| Missing a Javadoc comment. |
90
|
|
| Method 'setOffset' is not designed for extension - needs to be abstract, final or empty. |
95
|
|
| Missing a Javadoc comment. |
95
|
|
| Parameter offset should be final. |
95
|
|
| 'offset' hides a field. |
95
|
|
| Method 'getModuleOffset' is not designed for extension - needs to be abstract, final or empty. |
99
|
|
| Missing a Javadoc comment. |
99
|
|
| Method 'setRepository' is not designed for extension - needs to be abstract, final or empty. |
106
|
|
| Missing a Javadoc comment. |
106
|
|
| Parameter repository should be final. |
106
|
|
| 'repository' hides a field. |
106
|
|
| Method 'getRepository' is not designed for extension - needs to be abstract, final or empty. |
116
|
|
| Missing a Javadoc comment. |
116
|
|
| Method 'setUsername' is not designed for extension - needs to be abstract, final or empty. |
121
|
|
| Missing a Javadoc comment. |
121
|
|
| Parameter username should be final. |
121
|
|
| 'username' hides a field. |
121
|
|
| Method 'getUsername' is not designed for extension - needs to be abstract, final or empty. |
129
|
|
| Missing a Javadoc comment. |
129
|
nl/toolforge/karma/core/vc/cvsimpl/AdminHandler.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
51
|
|
| Missing a Javadoc comment. |
53
|
|
| Missing a Javadoc comment. |
54
|
|
| Missing a Javadoc comment. |
55
|
|
| Missing a Javadoc comment. |
57
|
|
| Parameter dir should be final. |
59
|
|
| Parameter name should be final. |
59
|
|
| Missing a Javadoc comment. |
64
|
|
| Parameter module should be final. |
64
|
|
| 'module' hides a field. |
64
|
|
| Line is longer than 120 characters. |
121
|
|
| Avoid inline conditionals. |
121
|
|
| Line is longer than 120 characters. |
128
|
|
| Missing a Javadoc comment. |
136
|
|
| Parameter entries should be final. |
136
|
|
| Missing a Javadoc comment. |
154
|
|
| Missing a Javadoc comment. |
168
|
|
| Missing a Javadoc comment. |
182
|
nl/toolforge/karma/core/vc/cvsimpl/CVSCommandMessage.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
nl/toolforge/karma/core/vc/cvsimpl/CVSCommandMessage.java
| Error | Line |
|---|
|
| Line contains a tab character. |
34
|
|
| Missing a Javadoc comment. |
34
|
|
| Parameter message should be final. |
34
|
|
| Line contains a tab character. |
35
|
|
| Line contains a tab character. |
36
|
|
| Line contains a tab character. |
38
|
|
| Missing a Javadoc comment. |
38
|
|
| Parameter message should be final. |
38
|
|
| Parameter parameters should be final. |
38
|
|
| Line contains a tab character. |
39
|
|
| Line contains a tab character. |
40
|
nl/toolforge/karma/core/vc/cvsimpl/CVSConnection.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
nl/toolforge/karma/core/vc/cvsimpl/CVSConnection.java
| Error | Line |
|---|
|
| Line contains a tab character. |
35
|
|
| Missing a Javadoc comment. |
35
|
|
| Line contains a tab character. |
36
|
|
| Missing a Javadoc comment. |
36
|
|
| Line contains a tab character. |
38
|
|
| Line is longer than 120 characters. |
39
|
|
| Line contains a tab character. |
39
|
|
| Line contains a tab character. |
40
|
|
| Line contains a tab character. |
41
|
|
| Line contains a tab character. |
42
|
|
| Line contains a tab character. |
43
|
|
| Line contains a tab character. |
44
|
|
| Parameter location should be final. |
44
|
|
| 'location' hides a field. |
44
|
|
| Line contains a tab character. |
46
|
|
| Line contains a tab character. |
47
|
|
| Line contains a tab character. |
48
|
|
| Line is longer than 120 characters. |
49
|
|
| Line contains a tab character. |
49
|
|
| Line contains a tab character. |
50
|
|
| Line contains a tab character. |
51
|
nl/toolforge/karma/core/vc/cvsimpl/CVSException.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
nl/toolforge/karma/core/vc/cvsimpl/CVSException.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
32
|
|
| Name 'EXCEPTION_PREFIX' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
32
|
|
| Variable 'EXCEPTION_PREFIX' must be private and have accessor methods. |
32
|
|
| Line contains a tab character. |
34
|
|
| Line contains a tab character. |
35
|
|
| Line contains a tab character. |
36
|
|
| Line contains a tab character. |
37
|
|
| Line contains a tab character. |
39
|
|
| Line contains a tab character. |
40
|
|
| Line contains a tab character. |
41
|
|
| Line contains a tab character. |
42
|
|
| Line contains a tab character. |
44
|
|
| Line contains a tab character. |
45
|
|
| Line contains a tab character. |
46
|
|
| Line is longer than 120 characters. |
47
|
|
| Line contains a tab character. |
47
|
|
| First sentence should end with a period. |
49
|
|
| Line contains a tab character. |
49
|
|
| Line contains a tab character. |
50
|
|
| Line contains a tab character. |
51
|
|
| Line is longer than 120 characters. |
52
|
|
| Line contains a tab character. |
52
|
|
| Line contains a tab character. |
54
|
|
| Line is longer than 120 characters. |
55
|
|
| Line contains a tab character. |
55
|
|
| Line contains a tab character. |
56
|
|
| Line contains a tab character. |
57
|
|
| Line is longer than 120 characters. |
58
|
|
| Line contains a tab character. |
58
|
|
| First sentence should end with a period. |
60
|
|
| Line contains a tab character. |
60
|
|
| Line contains a tab character. |
61
|
|
| Line contains a tab character. |
62
|
|
| Line contains a tab character. |
63
|
|
| Line contains a tab character. |
65
|
|
| Line is longer than 120 characters. |
66
|
|
| Line contains a tab character. |
66
|
|
| Line contains a tab character. |
67
|
|
| Line contains a tab character. |
68
|
|
| Line contains a tab character. |
69
|
|
| Missing a Javadoc comment. |
91
|
|
| Parameter errorCode should be final. |
91
|
|
| Missing a Javadoc comment. |
95
|
|
| Parameter t should be final. |
95
|
|
| Parameter errorCode should be final. |
95
|
|
| Missing a Javadoc comment. |
99
|
|
| Parameter errorCode should be final. |
99
|
|
| Parameter messageArguments should be final. |
99
|
|
| Missing a Javadoc comment. |
103
|
|
| Parameter t should be final. |
103
|
|
| Parameter errorCode should be final. |
103
|
|
| Parameter messageArguments should be final. |
103
|
nl/toolforge/karma/core/vc/cvsimpl/CVSModuleStatus.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
51
|
|
| Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
51
|
|
| Missing a Javadoc comment. |
53
|
|
| Missing a Javadoc comment. |
55
|
|
| Missing a Javadoc comment. |
57
|
|
| Missing a Javadoc comment. |
58
|
|
| Missing a Javadoc comment. |
59
|
|
| Missing a Javadoc comment. |
60
|
|
| Missing a Javadoc comment. |
61
|
|
| Parameter module should be final. |
70
|
|
| 'module' hides a field. |
70
|
|
| Parameter logInfo should be final. |
70
|
|
| 'logInfo' hides a field. |
70
|
|
| Missing a Javadoc comment. |
75
|
|
| Parameter module should be final. |
75
|
|
| 'module' hides a field. |
75
|
|
| Method 'setLogInformation' is not designed for extension - needs to be abstract, final or empty. |
79
|
|
| Missing a Javadoc comment. |
79
|
|
| Parameter logInfo should be final. |
79
|
|
| 'logInfo' hides a field. |
79
|
|
| Expected an @return tag. |
89
|
|
| Method 'getNextVersion' is not designed for extension - needs to be abstract, final or empty. |
89
|
|
| Method 'getNextMajorVersion' is not designed for extension - needs to be abstract, final or empty. |
119
|
|
| Missing a Javadoc comment. |
119
|
|
| Expected an @return tag. |
142
|
|
| Method 'getLastVersion' is not designed for extension - needs to be abstract, final or empty. |
142
|
|
| Method 'getLocalVersion' is not designed for extension - needs to be abstract, final or empty. |
161
|
|
| Expected @throws tag for 'CVSException'. |
161
|
|
| '+' is not preceded with whitespace. |
162
|
|
| '+' is not followed by whitespace. |
162
|
|
| Line is longer than 120 characters. |
181
|
|
| '+' is not preceded with whitespace. |
189
|
|
| '+' is not followed by whitespace. |
189
|
|
| '+' is not preceded with whitespace. |
192
|
|
| '+' is not followed by whitespace. |
192
|
|
| Method 'setExistsInRepository' is not designed for extension - needs to be abstract, final or empty. |
205
|
|
| Missing a Javadoc comment. |
205
|
|
| Parameter exists should be final. |
205
|
|
| Method 'existsInRepository' is not designed for extension - needs to be abstract, final or empty. |
209
|
|
| Missing a Javadoc comment. |
209
|
|
| Missing a Javadoc comment. |
213
|
|
| Parameter module should be final. |
213
|
|
| 'module' hides a field. |
213
|
|
| 'matchingList' hides a field. |
222
|
|
| Must have at least one statement. |
254
|
|
| Method 'connectionFailure' is not designed for extension - needs to be abstract, final or empty. |
267
|
|
| Missing a Javadoc comment. |
267
|
|
| Method 'authenticationFailure' is not designed for extension - needs to be abstract, final or empty. |
271
|
|
| Missing a Javadoc comment. |
271
|
|
| Method 'internalError' is not designed for extension - needs to be abstract, final or empty. |
275
|
|
| Missing a Javadoc comment. |
275
|
|
| Method 'setConnnectionFailure' is not designed for extension - needs to be abstract, final or empty. |
282
|
|
| Method 'setAuthenticationFailure' is not designed for extension - needs to be abstract, final or empty. |
286
|
|
| Missing a Javadoc comment. |
286
|
|
| Method 'setInternalError' is not designed for extension - needs to be abstract, final or empty. |
290
|
|
| Missing a Javadoc comment. |
290
|
nl/toolforge/karma/core/vc/cvsimpl/CVSRepository.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
47
|
|
| First sentence should end with a period. |
49
|
|
| Missing a Javadoc comment. |
54
|
|
| Missing a Javadoc comment. |
55
|
|
| Missing a Javadoc comment. |
56
|
|
| Missing a Javadoc comment. |
57
|
|
| Missing a Javadoc comment. |
59
|
|
| Parameter id should be final. |
59
|
|
| Expected an @return tag. |
68
|
|
| Method 'isAvailable' is not designed for extension - needs to be abstract, final or empty. |
68
|
|
| '3000' is a magic number. |
70
|
|
| Method 'connect' is not designed for extension - needs to be abstract, final or empty. |
76
|
|
| Missing a Javadoc comment. |
76
|
|
| Method 'setPassword' is not designed for extension - needs to be abstract, final or empty. |
106
|
|
| Missing a Javadoc comment. |
106
|
|
| Parameter password should be final. |
106
|
|
| 'password' hides a field. |
106
|
|
| Expected an @return tag. |
115
|
|
| Method 'getPassword' is not designed for extension - needs to be abstract, final or empty. |
115
|
|
| Method 'setProtocol' is not designed for extension - needs to be abstract, final or empty. |
126
|
|
| Parameter protocol should be final. |
126
|
|
| Method 'setPort' is not designed for extension - needs to be abstract, final or empty. |
134
|
|
| Missing a Javadoc comment. |
134
|
|
| Parameter port should be final. |
134
|
|
| Method 'setPort' is not designed for extension - needs to be abstract, final or empty. |
152
|
|
| Parameter port should be final. |
152
|
|
| Expected @param tag for 'port'. |
152
|
|
| Parameter repository should be final. |
167
|
|
| 'while' is not followed by whitespace. |
174
|
|
| Unclosed HTML tag found: <lu> |
184
|
|
| Extra HTML tag found: </ul> |
188
|
|
| Expected an @return tag. |
193
|
|
| Expected @throws tag for 'CVSException'. |
193
|
|
| Missing a Javadoc comment. |
198
|
|
| Parameter userName should be final. |
198
|
|
| Avoid inline conditionals. |
216
|
|
| Avoid inline conditionals. |
224
|
|
| Avoid inline conditionals. |
231
|
|
| Avoid inline conditionals. |
240
|
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
251
|
|
| Method 'asXML' is not designed for extension - needs to be abstract, final or empty. |
267
|
|
| Method 'asXML' is not designed for extension - needs to be abstract, final or empty. |
271
|
|
| Missing a Javadoc comment. |
271
|
|
| Parameter leftIndent should be final. |
271
|
|
| '+' should be on a new line. |
276
|
|
| '+' should be on a new line. |
277
|
|
| '+' should be on a new line. |
278
|
|
| '+' should be on a new line. |
279
|
|
| '+' should be on a new line. |
280
|
|
| '+' should be on a new line. |
281
|
|
| Avoid inline conditionals. |
289
|
|
| Avoid inline conditionals. |
290
|
|
| Avoid inline conditionals. |
292
|
nl/toolforge/karma/core/vc/cvsimpl/CVSResponseAdapter.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
nl/toolforge/karma/core/vc/cvsimpl/CVSResponseAdapter.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
52
|
|
| Missing a Javadoc comment. |
53
|
|
| Missing a Javadoc comment. |
55
|
|
| Missing a Javadoc comment. |
56
|
|
| Missing a Javadoc comment. |
58
|
|
| '{' is not followed by whitespace. |
58
|
|
| '}' is not preceded with whitespace. |
58
|
|
| Parameter response should be final. |
66
|
|
| 'response' hides a field. |
66
|
|
| Expected @param tag for 'response'. |
66
|
|
| Missing a Javadoc comment. |
70
|
|
| Parameter arguments should be final. |
70
|
|
| 'arguments' hides a field. |
70
|
|
| Missing a Javadoc comment. |
74
|
|
| Parameter args should be final. |
74
|
|
| Avoid inline conditionals. |
92
|
|
| Parameter event should be final. |
118
|
|
| '{' is not followed by whitespace. |
118
|
|
| '}' is not preceded with whitespace. |
118
|
|
| Line is longer than 120 characters. |
124
|
|
| Parameter event should be final. |
131
|
|
| '{' is not followed by whitespace. |
131
|
|
| '}' is not preceded with whitespace. |
131
|
|
| Parameter event should be final. |
138
|
|
| '{' is not followed by whitespace. |
138
|
|
| '}' is not preceded with whitespace. |
138
|
|
| Parameter event should be final. |
148
|
|
| First sentence should end with a period. |
161
|
|
| Line is longer than 120 characters. |
162
|
|
| Parameter event should be final. |
166
|
|
| Parameter event should be final. |
173
|
|
| Parameter event should be final. |
181
|
|
| Must have at least one statement. |
195
|
|
| Line is longer than 120 characters. |
203
|
nl/toolforge/karma/core/vc/cvsimpl/CVSRevision.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
nl/toolforge/karma/core/vc/cvsimpl/CVSRunner.java
| Error | Line |
|---|
|
| Unused import - nl.toolforge.karma.core.cmd.Command. |
26
|
|
| Missing a Javadoc comment. |
90
|
|
| Missing a Javadoc comment. |
92
|
|
| Missing a Javadoc comment. |
94
|
|
| Missing a Javadoc comment. |
95
|
|
| Missing a Javadoc comment. |
97
|
|
| Missing a Javadoc comment. |
99
|
|
| Line is longer than 120 characters. |
109
|
|
| Line is longer than 120 characters. |
111
|
|
| Parameter location should be final. |
114
|
|
| 'location' hides a field. |
114
|
|
| Missing a Javadoc comment. |
157
|
|
| Parameter location should be final. |
157
|
|
| 'location' hides a field. |
157
|
|
| Missing a Javadoc comment. |
161
|
|
| Missing a Javadoc comment. |
165
|
|
| Parameter response should be final. |
174
|
|
| Parameter module should be final. |
186
|
|
| Expected @param tag for 'module'. |
186
|
|
| Missing a Javadoc comment. |
198
|
|
| Parameter file should be final. |
198
|
|
| Missing a Javadoc comment. |
235
|
|
| Parameter module should be final. |
235
|
|
| Parameter comment should be final. |
235
|
|
| Line is longer than 120 characters. |
240
|
|
| Line is longer than 120 characters. |
247
|
|
| Line is longer than 120 characters. |
261
|
|
| Parameter module should be final. |
263
|
|
| Parameter version should be final. |
263
|
|
| Missing a Javadoc comment. |
269
|
|
| Parameter module should be final. |
269
|
|
| Parameter module should be final. |
282
|
|
| Parameter developmentLine should be final. |
282
|
|
| Parameter version should be final. |
282
|
|
| Expected @param tag for 'version'. |
282
|
|
| Line is longer than 120 characters. |
303
|
|
| Missing a Javadoc comment. |
323
|
|
| Parameter module should be final. |
323
|
|
| Parameter module should be final. |
342
|
|
| Parameter module should be final. |
349
|
|
| Parameter version should be final. |
349
|
|
| Parameter module should be final. |
361
|
|
| Parameter developmentLine should be final. |
361
|
|
| Parameter version should be final. |
361
|
|
| Expected @throws tag for 'CVSException'. |
361
|
|
| Missing a Javadoc comment. |
402
|
|
| Parameter module should be final. |
402
|
|
| Parameter files should be final. |
402
|
|
| Parameter dirs should be final. |
402
|
|
| Avoid inline conditionals. |
404
|
|
| Avoid inline conditionals. |
405
|
|
| Missing a Javadoc comment. |
417
|
|
| Parameter module should be final. |
417
|
|
| Parameter files should be final. |
417
|
|
| Parameter dirs should be final. |
417
|
|
| Avoid inline conditionals. |
419
|
|
| Avoid inline conditionals. |
420
|
|
| '=' is not preceded with whitespace. |
436
|
|
| '=' is not followed by whitespace. |
436
|
|
| '=' is not preceded with whitespace. |
459
|
|
| '=' is not followed by whitespace. |
459
|
|
| Missing a Javadoc comment. |
498
|
|
| Parameter developmentLine should be final. |
498
|
|
| Parameter module should be final. |
498
|
|
| Parameter file should be final. |
498
|
|
| Parameter message should be final. |
498
|
|
| Missing a Javadoc comment. |
511
|
|
| Parameter module should be final. |
511
|
|
| Parameter comment should be final. |
511
|
|
| Parameter version should be final. |
511
|
|
| Missing a Javadoc comment. |
525
|
|
| Parameter module should be final. |
525
|
|
| Parameter version should be final. |
525
|
|
| Line is longer than 120 characters. |
527
|
|
| Missing a Javadoc comment. |
535
|
|
| Parameter module should be final. |
535
|
|
| Parameter symbolicName should be final. |
535
|
|
| Parameter branch should be final. |
535
|
|
| Expected an @return tag. |
550
|
|
| Parameter module should be final. |
550
|
|
| Expected @param tag for 'module'. |
550
|
|
| Expected @throws tag for 'CVSException'. |
550
|
|
| Parameter module should be final. |
606
|
|
| Parameter module should be final. |
620
|
|
| Line is longer than 120 characters. |
627
|
|
| Expected an @return tag. |
640
|
|
| Parameter module should be final. |
640
|
|
| Expected @param tag for 'module'. |
640
|
|
| Missing a Javadoc comment. |
657
|
|
| Parameter module should be final. |
657
|
|
| Parameter version should be final. |
657
|
|
| Missing a Javadoc comment. |
661
|
|
| Parameter module should be final. |
661
|
|
| Parameter symbolicName should be final. |
661
|
|
| Parameter command should be final. |
686
|
|
| Parameter contextDirectory should be final. |
687
|
|
| Parameter args should be final. |
687
|
|
| '3' is a magic number. |
706
|
|
| '3' is a magic number. |
744
|
|
| Line is longer than 120 characters. |
748
|
|
| '++' is preceded with whitespace. |
753
|
|
| Parameter module should be final. |
785
|
|
| Parameter eventType should be final. |
786
|
|
| Parameter version should be final. |
787
|
|
| Parameter datetime should be final. |
788
|
|
| Parameter author should be final. |
789
|
|
| Parameter comment should be final. |
790
|
|
| Expected @throws tag for 'ModuleHistoryException'. |
790
|
|
| '{' should be on the previous line. |
791
|
|
| Line is longer than 120 characters. |
811
|
nl/toolforge/karma/core/vc/cvsimpl/CVSRuntimeException.java
| Error | Line |
|---|
|
| Line is longer than 120 characters. |
24
|
|
| Line is longer than 120 characters. |
30
|
|
| Missing a Javadoc comment. |
39
|
|
| Missing a Javadoc comment. |
40
|
|
| Parameter errorCode should be final. |
48
|
|
| 'errorCode' hides a field. |
48
|
|
| Missing a Javadoc comment. |
52
|
|
| Parameter t should be final. |
52
|
|
| Parameter errorCode should be final. |
52
|
|
| 'errorCode' hides a field. |
52
|
|
| Missing a Javadoc comment. |
57
|
|
| Parameter errorCode should be final. |
57
|
|
| 'errorCode' hides a field. |
57
|
|
| Parameter messageArguments should be final. |
57
|
|
| 'messageArguments' hides a field. |
57
|
|
| Missing a Javadoc comment. |
62
|
|
| Parameter t should be final. |
62
|
|
| Parameter errorCode should be final. |
62
|
|
| 'errorCode' hides a field. |
62
|
|
| Parameter messageArguments should be final. |
62
|
|
| 'messageArguments' hides a field. |
62
|
|
| Missing a Javadoc comment. |
69
|
|
| Expected an @return tag. |
80
|
|
| Redundant 'final' modifier. |
80
|
|
| Missing a Javadoc comment. |
84
|
|
| Redundant 'final' modifier. |
84
|
nl/toolforge/karma/core/vc/cvsimpl/CVSTag.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
nl/toolforge/karma/core/vc/cvsimpl/CVSTag.java
| Error | Line |
|---|
|
| Line contains a tab character. |
31
|
|
| Missing a Javadoc comment. |
31
|
|
| Line contains a tab character. |
33
|
|
| Line contains a tab character. |
34
|
|
| Line contains a tab character. |
35
|
|
| Line contains a tab character. |
36
|
|
| Parameter symbolicName should be final. |
36
|
|
| 'symbolicName' hides a field. |
36
|
|
| Expected @param tag for 'symbolicName'. |
36
|
|
| Line contains a tab character. |
38
|
|
| Line contains a tab character. |
39
|
|
| Line contains a tab character. |
40
|
|
| Line contains a tab character. |
41
|
|
| Line contains a tab character. |
43
|
|
| Missing a Javadoc comment. |
43
|
|
| Parameter symbolicName should be final. |
43
|
|
| 'symbolicName' hides a field. |
43
|
|
| Parameter isBranch should be final. |
43
|
|
| Line contains a tab character. |
44
|
|
| Line contains a tab character. |
45
|
|
| Line contains a tab character. |
47
|
|
| Line contains a tab character. |
48
|
|
| Line contains a tab character. |
49
|
|
| Line contains a tab character. |
50
|
|
| Line contains a tab character. |
51
|
|
| Line contains a tab character. |
52
|
|
| Line contains a tab character. |
54
|
|
| Line contains a tab character. |
55
|
|
| Line contains a tab character. |
56
|
|
| Line contains a tab character. |
57
|
|
| Line contains a tab character. |
59
|
|
| Method 'isBranch' is not designed for extension - needs to be abstract, final or empty. |
59
|
|
| Missing a Javadoc comment. |
59
|
|
| Line contains a tab character. |
60
|
|
| Line contains a tab character. |
61
|
|
| Line contains a tab character. |
63
|
|
| Line contains a tab character. |
64
|
|
| Line contains a tab character. |
65
|
|
| Line contains a tab character. |
66
|
|
| Line contains a tab character. |
67
|
|
| Line contains a tab character. |
68
|
|
| Method 'isSticky' is not designed for extension - needs to be abstract, final or empty. |
68
|
|
| Line contains a tab character. |
69
|
|
| Line contains a tab character. |
70
|
|
| Line contains a tab character. |
72
|
|
| Method 'getSymbolicName' is not designed for extension - needs to be abstract, final or empty. |
72
|
|
| Missing a Javadoc comment. |
72
|
|
| Line contains a tab character. |
73
|
|
| Line contains a tab character. |
74
|
|
| Line contains a tab character. |
76
|
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
76
|
|
| Missing a Javadoc comment. |
76
|
|
| Line contains a tab character. |
77
|
|
| Line contains a tab character. |
78
|
|
| Line contains a tab character. |
80
|
|
| Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. |
80
|
|
| Missing a Javadoc comment. |
80
|
|
| Line contains a tab character. |
81
|
|
| Line contains a tab character. |
82
|
|
| Line contains a tab character. |
84
|
|
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
84
|
|
| Missing a Javadoc comment. |
84
|
|
| Parameter o should be final. |
84
|
|
| Line contains a tab character. |
86
|
|
| Line contains a tab character. |
87
|
|
| Line contains a tab character. |
88
|
|
| Line contains a tab character. |
90
|
|
| Line contains a tab character. |
91
|
nl/toolforge/karma/core/vc/cvsimpl/ExtClient.java
| Error | Line |
|---|
|
| Line does not match expected header line of '/*'. |
1
|
|
| Missing a Javadoc comment. |
29
|
|
| Missing a Javadoc comment. |
31
|
|
| Parameter handler should be final. |
31
|
|
| Missing a Javadoc comment. |
35
|
|
| Missing a Javadoc comment. |
37
|
|
| Parameter command should be final. |
37
|
|
| Parameter contextDirectory should be final. |
37
|
|
| Parameter location should be final. |
37
|
|
| Missing a Javadoc comment. |
80
|
|
| Redundant 'final' modifier. |
80
|
|
| Parameter buildFile should be final. |
80
|
|
| Missing a Javadoc comment. |
105
|
|
| Parameter listener should be final. |
105
|
|
| 'listener' hides a field. |
105
|
nl/toolforge/karma/core/vc/cvsimpl/InitializationException.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
nl/toolforge/karma/core/vc/cvsimpl/InitializationException.java
| Error | Line |
|---|
|
| Line contains a tab character. |
29
|
|
| Missing a Javadoc comment. |
29
|
|
| Parameter message should be final. |
29
|
|
| Line contains a tab character. |
30
|
|
| Line contains a tab character. |
31
|
nl/toolforge/karma/core/vc/cvsimpl/LogParser.java
| Error | Line |
|---|
|
| Line does not match expected header line of '/*'. |
1
|
|
| Missing a Javadoc comment. |
24
|
|
| Missing a Javadoc comment. |
25
|
|
| Missing a Javadoc comment. |
27
|
|
| Missing a Javadoc comment. |
29
|
|
| Method 'messageLogged' is not designed for extension - needs to be abstract, final or empty. |
36
|
|
| Parameter event should be final. |
36
|
|
| Expected @param tag for 'event'. |
36
|
|
| Missing a Javadoc comment. |
55
|
|
| Parameter line should be final. |
55
|
|
| Line has trailing spaces. |
66
|
|
| Method 'getLogInformation' is not designed for extension - needs to be abstract, final or empty. |
67
|
|
| Missing a Javadoc comment. |
67
|
|
| Parameter e should be final. |
78
|
|
| Parameter e should be final. |
84
|
|
| Parameter e should be final. |
90
|
|
| Parameter e should be final. |
96
|
|
| Parameter e should be final. |
102
|
|
| Parameter e should be final. |
108
|
|
| Parameter e should be final. |
114
|
nl/toolforge/karma/core/vc/cvsimpl/Utils.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
37
|
|
| Utility classes should not have a public or default constructor. |
37
|
|
| Missing a Javadoc comment. |
39
|
|
| Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
39
|
|
| Line is longer than 120 characters. |
54
|
|
| Parameter module should be final. |
56
|
|
| Parameter developmentLine should be final. |
56
|
|
| Parameter version should be final. |
56
|
|
| '+' should be on a new line. |
73
|
|
| 'cast' is not followed by whitespace. |
76
|
|
| Missing a Javadoc comment. |
94
|
|
| Parameter module should be final. |
94
|
|
| Parameter version should be final. |
94
|
|
| Missing a Javadoc comment. |
98
|
|
| Parameter patch should be final. |
98
|
|
| Missing a Javadoc comment. |
102
|
|
| Parameter module should be final. |
102
|
|
| Missing a Javadoc comment. |
117
|
|
| Parameter module should be final. |
117
|
|
| Missing a Javadoc comment. |
125
|
|
| Parameter module should be final. |
125
|
nl/toolforge/karma/core/vc/cvsimpl/threads/CVSLogThread.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
44
|
|
| Missing a Javadoc comment. |
46
|
|
| Parameter module should be final. |
46
|
|
| Method 'run' is not designed for extension - needs to be abstract, final or empty. |
53
|
|
| '||' should be on a new line. |
73
|
nl/toolforge/karma/core/vc/cvsimpl/threads/PatchLineThread.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
39
|
|
| Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
39
|
|
| Missing a Javadoc comment. |
41
|
|
| Parameter module should be final. |
41
|
|
| Method 'run' is not designed for extension - needs to be abstract, final or empty. |
48
|
|
| Line is longer than 120 characters. |
55
|
nl/toolforge/karma/core/vc/model/MainLine.java
| Error | Line |
|---|
|
| interfaces should describe a type and hence have methods. |
28
|
|
| First sentence should end with a period. |
30
|
|
| Line contains a tab character. |
30
|
|
| Line contains a tab character. |
31
|
|
| Line contains a tab character. |
32
|
|
| Line contains a tab character. |
33
|
|
| Redundant 'public' modifier. |
33
|
nl/toolforge/karma/core/vc/model/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
nl/toolforge/karma/core/vc/svnimpl/SVNException.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
nl/toolforge/karma/core/vc/svnimpl/SVNException.java
| Error | Line |
|---|
|
| Line contains a tab character. |
33
|
|
| Line contains a tab character. |
34
|
|
| Line contains a tab character. |
35
|
|
| Line contains a tab character. |
36
|
|
| Line contains a tab character. |
39
|
|
| Line contains a tab character. |
40
|
|
| Line contains a tab character. |
41
|
|
| Line contains a tab character. |
42
|
|
| Missing a Javadoc comment. |
44
|
|
| Parameter errorCode should be final. |
44
|
|
| Missing a Javadoc comment. |
48
|
|
| Parameter t should be final. |
48
|
|
| Parameter errorCode should be final. |
48
|
|
| Missing a Javadoc comment. |
52
|
|
| Parameter errorCode should be final. |
52
|
|
| Parameter messageArguments should be final. |
52
|
|
| Missing a Javadoc comment. |
56
|
|
| Parameter t should be final. |
56
|
|
| Parameter errorCode should be final. |
56
|
|
| Parameter messageArguments should be final. |
56
|
|
| Line is longer than 120 characters. |
57
|
nl/toolforge/karma/core/vc/svnimpl/SubversionLocationImpl.java
| Error | Line |
|---|
|
| Line contains a tab character. |
31
|
|
| Missing a Javadoc comment. |
31
|
|
| Line contains a tab character. |
32
|
|
| Missing a Javadoc comment. |
32
|
|
| Line contains a tab character. |
34
|
|
| Missing a Javadoc comment. |
34
|
|
| Parameter id should be final. |
34
|
|
| Line contains a tab character. |
35
|
|
| Line contains a tab character. |
36
|
|
| Line contains a tab character. |
38
|
|
| Missing a Javadoc comment. |
38
|
|
| Parameter username should be final. |
38
|
|
| 'username' hides a field. |
38
|
|
| Line contains a tab character. |
39
|
|
| Line contains a tab character. |
40
|
|
| Line contains a tab character. |
42
|
|
| Missing a Javadoc comment. |
42
|
|
| Parameter encodedPassword should be final. |
42
|
|
| Line contains a tab character. |
44
|
|
| Line contains a tab character. |
45
|
|
| Line contains a tab character. |
46
|
|
| Line contains a tab character. |
47
|
|
| Expected an @return tag. |
53
|
|
| Missing a Javadoc comment. |
57
|
|
| Missing a Javadoc comment. |
61
|
nl/toolforge/karma/core/vc/svnimpl/SubversionRepository.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
36
|
|
| Parameter id should be final. |
36
|
|
| Method 'isAvailable' is not designed for extension - needs to be abstract, final or empty. |
40
|
|
| Missing a Javadoc comment. |
40
|
|
| Missing a Javadoc comment. |
44
|
|
| Method 'asXML' is not designed for extension - needs to be abstract, final or empty. |
48
|
|
| Missing a Javadoc comment. |
48
|
nl/toolforge/karma/core/vc/svnimpl/SubversionRevision.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
nl/toolforge/karma/core/vc/svnimpl/SubversionRunner.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
nl/toolforge/karma/core/vc/svnimpl/SubversionRunner.java
| Error | Line |
|---|
|
| First sentence should end with a period. |
32
|
|
| Missing a Javadoc comment. |
40
|
|
| Parameter module should be final. |
40
|
|
| Parameter developmentLine should be final. |
40
|
|
| Parameter version should be final. |
40
|
|
| Missing a Javadoc comment. |
44
|
|
| Parameter location should be final. |
44
|
|
| Missing a Javadoc comment. |
48
|
|
| Parameter file should be final. |
48
|
|
| Missing a Javadoc comment. |
52
|
|
| Parameter module should be final. |
52
|
|
| Parameter comment should be final. |
52
|
|
| Missing a Javadoc comment. |
56
|
|
| Parameter response should be final. |
56
|
|
| Missing a Javadoc comment. |
60
|
|
| Parameter module should be final. |
60
|
|
| Parameter files should be final. |
60
|
|
| Parameter dirs should be final. |
60
|
|
| Missing a Javadoc comment. |
64
|
|
| Parameter module should be final. |
64
|
|
| Parameter files should be final. |
64
|
|
| Parameter dirs should be final. |
64
|
|
| Missing a Javadoc comment. |
68
|
|
| Parameter module should be final. |
68
|
|
| Missing a Javadoc comment. |
72
|
|
| Parameter module should be final. |
72
|
|
| Parameter version should be final. |
72
|
|
| Missing a Javadoc comment. |
76
|
|
| Parameter module should be final. |
76
|
|
| Parameter developmentLine should be final. |
76
|
|
| Parameter version should be final. |
76
|
|
| Missing a Javadoc comment. |
80
|
|
| Parameter module should be final. |
80
|
|
| Missing a Javadoc comment. |
84
|
|
| Parameter module should be final. |
84
|
|
| Parameter version should be final. |
84
|
|
| Missing a Javadoc comment. |
88
|
|
| Parameter module should be final. |
88
|
|
| Parameter comment should be final. |
88
|
|
| Parameter version should be final. |
88
|
|
| Missing a Javadoc comment. |
92
|
|
| Parameter module should be final. |
92
|
|
| Missing a Javadoc comment. |
96
|
|
| Parameter module should be final. |
96
|
|
| Missing a Javadoc comment. |
100
|
|
| Parameter module should be final. |
100
|
nl/toolforge/karma/core/vc/threads/ParallelRunner.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
42
|
|
| Variable 'logger' must be private and have accessor methods. |
42
|
|
| Missing a Javadoc comment. |
44
|
|
| Missing a Javadoc comment. |
46
|
|
| Missing a Javadoc comment. |
47
|
|
| Missing a Javadoc comment. |
49
|
|
| Parameter manifest should be final. |
58
|
|
| 'manifest' hides a field. |
58
|
|
| Parameter threadClass should be final. |
58
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
68
|
|
| Parameter delayInMilliseconds should be final. |
68
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
80
|
|
| ',' is not followed by whitespace. |
81
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
96
|
|
| Parameter blockSize should be final. |
96
|
|
| Parameter delayInMilliseconds should be final. |
96
|
|
| Must have at least one statement. |
127
|
|
| Missing a Javadoc comment. |
145
|
|
| Parameter module should be final. |
145
|
|
| Parameter result should be final. |
145
|
|
| Method 'retrieveResults' is not designed for extension - needs to be abstract, final or empty. |
156
|
nl/toolforge/karma/core/vc/threads/RunnerResult.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line has trailing spaces. |
5
|
nl/toolforge/karma/core/vc/threads/RunnerThread.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
30
|
|
| Missing a Javadoc comment. |
32
|
|
| Variable 'exception' must be private and have accessor methods. |
32
|
|
| Missing a Javadoc comment. |
33
|
|
| Variable 'result' must be private and have accessor methods. |
33
|
|
| Missing a Javadoc comment. |
34
|
|
| Missing a Javadoc comment. |
36
|
|
| Parameter module should be final. |
36
|
|
| 'module' hides a field. |
36
|
|
| Method 'startRunning' is not designed for extension - needs to be abstract, final or empty. |
48
|
|
| Method 'stopRunning' is not designed for extension - needs to be abstract, final or empty. |
55
|
|
| Expected an @return tag. |
64
|
|
| Missing a Javadoc comment. |
68
|
|
| Method 'getModule' is not designed for extension - needs to be abstract, final or empty. |
78
|
|
| Method 'getException' is not designed for extension - needs to be abstract, final or empty. |
85
|
|
| Missing a Javadoc comment. |
85
|
nl/toolforge/karma/core/vc/threads/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
